Bugzilla – Attachment 100479 Details for
Bug 24378
Change wording on AUTO_RENEWALS notice in updatedatabase
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24378: Reword notice in updatedatabase.pl for grammar and clarity
Bug-24378-Reword-notice-in-updatedatabasepl-for-gr.patch (text/plain), 2.42 KB, created by
David Nind
on 2020-03-10 19:38:38 UTC
(
hide
)
Description:
Bug 24378: Reword notice in updatedatabase.pl for grammar and clarity
Filename:
MIME Type:
Creator:
David Nind
Created:
2020-03-10 19:38:38 UTC
Size:
2.42 KB
patch
obsolete
>From 5fe374913ce7b9b968b78b68124bd3bd2250661f Mon Sep 17 00:00:00 2001 >From: Andrew Fuerste-Henry <andrew@bywatersolutions.com> >Date: Tue, 10 Mar 2020 00:55:01 +0000 >Subject: [PATCH] Bug 24378: Reword notice in updatedatabase.pl for grammar and > clarity > >Test plan: >- install patch >- update databse >- confirm notice name is now in sentence-case >- confirm too-many error text now reads "reached" rather than "reach" > >Signed-off-by: David Nind <david@davidnind.com> >--- > installer/data/mysql/updatedatabase.pl | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > >diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl >index 26c254206d..47074523dd 100755 >--- a/installer/data/mysql/updatedatabase.pl >+++ b/installer/data/mysql/updatedatabase.pl >@@ -14438,25 +14438,25 @@ if( CheckVersion( $DBversion ) ) { > } > > $dbh->do(q{ >- INSERT INTO letter (module, code, name, title, content, message_transport_type) VALUES ('circulation', 'AUTO_RENEWALS', 'notification on auto renewing', 'Auto renewals', >+ INSERT INTO letter (module, code, name, title, content, message_transport_type) VALUES ('circulation', 'AUTO_RENEWALS', 'Notification of automatic renewal', 'Automatic renewal notice', > "Dear [% borrower.firstname %] [% borrower.surname %], > [% IF checkout.auto_renew_error %] >-The following item [% biblio.title %] has not been correctly renewed >+The following item, [% biblio.title %], has not been renewed because: > [% IF checkout.auto_renew_error == 'too_many' %] >-You have reach the maximum of checkouts possible. >+You have reached the maximum of checkouts possible. > [% ELSIF checkout.auto_renew_error == 'on_reserve' %] > This item is on hold for another patron. > [% ELSIF checkout.auto_renew_error == 'restriction' %] > You are currently restricted. > [% ELSIF checkout.auto_renew_error == 'overdue' %] >-You have overdues. >+You have overdue items. > [% ELSIF checkout.auto_renew_error == 'auto_too_late' %] >-It\'s too late to renew this checkout. >+It\'s too late to renew this item. > [% ELSIF checkout.auto_renew_error == 'auto_too_much_oweing' %] >-You have too much unpaid fines. >+Your total unpaid fines are too high. > [% END %] > [% ELSE %] >-The following item [% biblio.title %] has correctly been renewed and is now due [% checkout.date_due %] >+The following item, [% biblio.title %], has correctly been renewed and is now due on [% checkout.date_due %] > [% END %]", 'email'); > }); > >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24378
:
100309
|
100416
|
100417
|
100479
|
100480
|
100485
|
102827
|
102828
|
102871
|
102872
|
104683
|
104701
|
104702
|
104703
|
104704