Attachment 100514 Details for Bug 4461 – Bug 4461: Redirect to 404 if KohaAdminEmailAddress is not defined

[patch] Bug 4461: Redirect to 404 if KohaAdminEmailAddress is not defined

Bug-4461-Redirect-to-404-if-KohaAdminEmailAddress-.patch (text/plain), 1.70 KB, created by Martin Renvoize (ashimema) on 2020-03-11 09:12:25 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2020-03-11 09:12:25 UTC

Size: 1.70 KB

patch

obsolete

>From 27cb433a21ef3540e5e6f505fc9aa1783551a01b Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 26 Feb 2020 11:41:39 +0100
>Subject: [PATCH] Bug 4461: Redirect to 404 if KohaAdminEmailAddress is not
> defined
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> .../intranet-tmpl/prog/en/modules/admin/preferences/opac.pref | 2 ++
> opac/opac-reportproblem.pl                                    | 4 +++-
> 2 files changed, 5 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
>index 52d000d715..99e17e7660 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
>@@ -376,6 +376,8 @@ OPAC:
>                   yes: Allow
>                   no: "Don't allow"
>             - patrons to submit problem reports for OPAC pages to the library or Koha Administrator.
>+            - "<br/>"
>+            - "<strong>NOTE:</strong> You must have KohaAdminEmailAddress enabled."
>         -
>             - pref: opacuserlogin
>               choices:
>diff --git a/opac/opac-reportproblem.pl b/opac/opac-reportproblem.pl
>index 9934ccc6b8..e12c5d5562 100644
>--- a/opac/opac-reportproblem.pl
>+++ b/opac/opac-reportproblem.pl
>@@ -40,7 +40,9 @@ my ( $template, $borrowernumber, $cookie ) = get_template_and_user(
>     }
> );
> 
>-if ( !C4::Context->preference('OPACReportProblem') ){
>+if (   !C4::Context->preference('OPACReportProblem')
>+    || !C4::Context->preference('KohaAdminEmailAddress') )
>+{
>     print $input->redirect("/cgi-bin/koha/errors/404.pl");
> }
> 
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 4461: 58887 | 59032 | 61654 | 65871 | 66253 | 66323 | 66324 | 98687 | 98688 | 98689 | 98725 | 99551 | 99599 | 99600 | 99601 | 99602 | 99603 | 99633 | 99635 | 99636 | 99637 | 99638 | 99639 | 99929 | 99930 | 99931 | 99932 | 99933 | 99934 | 99935 | 99936 | 99937 | 99938 | 99939 | 99940 | 99941 | 99942 | 100488 | 100489 | 100490 | 100491 | 100492 | 100493 | 100494 | 100495 | 100496 | 100497 | 100498 | 100499 | 100500 | 100506 | 100507 | 100508 | 100509 | 100510 | 100511 | 100512 | 100513 | 100514 | 100515 | 100516 | 100517 | 100518 | 100519 | 100520 | 100521 | 100522 | 100523 | 100524 | 100619 | 100989 | 100990 | 102188 | 102189 | 102190 | 102191 | 102192 | 102193 | 102194 | 102195 | 102196 | 102198 | 102200 | 102201 | 102202 | 102203 | 102204 | 102205 | 102206 | 102207 | 102208 | 102209 | 102210 | 102211 | 102253 | 102279 | 102281 | 102308 | 102309 | 102310 | 102311 | 102312 | 102313 | 102314 | 102315 | 102316 | 102317 | 102318 | 102319 | 102320 | 102321 | 102322 | 102323 | 102324 | 102325 | 102326 | 102327 | 102328 | 102329 | 102330 | 102331 | 102358 | 102359 | 102360 | 102361 | 102362 | 102363 | 102364 | 102365 | 102366 | 102367 | 102368 | 102369 | 102370 | 102371 | 102372 | 102373 | 102374 | 102375 | 102376 | 102377 | 102378 | 102379 | 102380 | 102381 | 102382 | 102383 | 102384 | 102385 | 102386