Bugzilla – Attachment 100618 Details for
Bug 24767
"Claim returned" feature cannot be turned off
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24767: "Claim returned" feature cannot be turned off
Bug-24767-Claim-returned-feature-cannot-be-turned-.patch (text/plain), 7.68 KB, created by
Kyle M Hall (khall)
on 2020-03-12 11:11:22 UTC
(
hide
)
Description:
Bug 24767: "Claim returned" feature cannot be turned off
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2020-03-12 11:11:22 UTC
Size:
7.68 KB
patch
obsolete
>From 01168282a878e2c671fbae51f60a5b40b84b2c35 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Thu, 12 Mar 2020 07:07:48 -0400 >Subject: [PATCH] Bug 24767: "Claim returned" feature cannot be turned off > >The ability to claim an item "claim returned" is not there if the syspref is empty, however, the Claim Returned tab is stil present on the patrons detail page. > >Test Plan: >1) Ensure ClaimReturnedLostValue is not set >2) Note the claims tabs on the circulation and patron details pages >3) Apply this patch >4) Refresh those pages >5) The claims tabs should be gone! >--- > .../prog/en/modules/circ/circulation.tt | 40 ++++++++++--------- > .../prog/en/modules/members/moremember.tt | 40 ++++++++++--------- > 2 files changed, 44 insertions(+), 36 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >index 1eeb19e3af..15c40b1cd8 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >@@ -861,23 +861,25 @@ > </li> > [% END %] > >- <li> >- [% IF ( patron.return_claims.count ) %] >- <a href="#return-claims" id="return-claims-tab"> >- <span id="return-claims-count-resolved">[% patron.return_claims.resolved.count | html %]</span> >- / >- <span id="return-claims-count-unresolved">[% patron.return_claims.unresolved.count | html %]</span> >- Claim(s) >- </a> >- [% ELSE %] >- <a href="#return-claims" id="return-claims-tab"> >- <span id="return-claims-count-resolved">0</span> >- / >- <span id="return-claims-count-unresolved">0</span> >- Claim(s) >- </a> >- [% END %] >- </li> >+ [% IF Koha.Preference('ClaimReturnedLostValue') %] >+ <li> >+ [% IF ( patron.return_claims.count ) %] >+ <a href="#return-claims" id="return-claims-tab"> >+ <span id="return-claims-count-resolved">[% patron.return_claims.resolved.count | html %]</span> >+ / >+ <span id="return-claims-count-unresolved">[% patron.return_claims.unresolved.count | html %]</span> >+ Claim(s) >+ </a> >+ [% ELSE %] >+ <a href="#return-claims" id="return-claims-tab"> >+ <span id="return-claims-count-resolved">0</span> >+ / >+ <span id="return-claims-count-unresolved">0</span> >+ Claim(s) >+ </a> >+ [% END %] >+ </li> >+ [% END %] > > <li><a id="debarments-tab-link" href="#reldebarments">[% debarments.count | html %] Restrictions</a></li> > >@@ -962,7 +964,9 @@ > [% END # /IF holds_count %] > </div> <!-- /#reserves --> > >- [% INCLUDE 'patron-return-claims.inc' %] >+ [% IF Koha.Preference('ClaimReturnedLostValue') %] >+ [% INCLUDE 'patron-return-claims.inc' %] >+ [% END %] > > [% IF Koha.Preference('ArticleRequests') %] > [% INCLUDE 'patron-article-requests.inc' %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt >index cfc2a0ab23..51980f2806 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt >@@ -722,23 +722,25 @@ > </li> > [% END %] > >- <li> >- [% IF ( patron.return_claims.count ) %] >- <a href="#return-claims" id="return-claims-tab"> >- <span id="return-claims-count-resolved">[% patron.return_claims.resolved.count | html %]</span> >- / >- <span id="return-claims-count-unresolved">[% patron.return_claims.unresolved.count | html %]</span> >- Claim(s) >- </a> >- [% ELSE %] >- <a href="#return-claims" id="return-claims-tab"> >- <span id="return-claims-count-resolved">0</span> >- / >- <span id="return-claims-count-unresolved">0</span> >- Claim(s) >- </a> >- [% END %] >- </li> >+ [% IF Koha.Preference('ClaimReturnedLostValue') %] >+ <li> >+ [% IF ( patron.return_claims.count ) %] >+ <a href="#return-claims" id="return-claims-tab"> >+ <span id="return-claims-count-resolved">[% patron.return_claims.resolved.count | html %]</span> >+ / >+ <span id="return-claims-count-unresolved">[% patron.return_claims.unresolved.count | html %]</span> >+ Claim(s) >+ </a> >+ [% ELSE %] >+ <a href="#return-claims" id="return-claims-tab"> >+ <span id="return-claims-count-resolved">0</span> >+ / >+ <span id="return-claims-count-unresolved">0</span> >+ Claim(s) >+ </a> >+ [% END %] >+ </li> >+ [% END %] > > <li> > <a id="debarments-tab-link" href="#reldebarments">[% debarments.size | html %] Restrictions</a> >@@ -834,7 +836,9 @@ > </div> [% # /div#reserves %] > [% END %] > >- [% INCLUDE 'patron-return-claims.inc' %] >+ [% IF Koha.Preference('ClaimReturnedLostValue') %] >+ [% INCLUDE 'patron-return-claims.inc' %] >+ [% END %] > > [% IF Koha.Preference('ArticleRequests') %] > [% INCLUDE 'patron-article-requests.inc' %] >-- >2.21.1 (Apple Git-122.3)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24767
:
100618
|
100620
|
100640