Bugzilla – Attachment 100639 Details for
Bug 23357
overdue_notices.pl can send library doubled emails for patrons with no email/sms if both transports enabled
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23357: (follow-up) Do not generate twice the same print notice
Bug-23357-Do-not-generate-twice-the-same-print-not.patch (text/plain), 3.78 KB, created by
Nick Clemens (kidclamp)
on 2020-03-12 14:14:42 UTC
(
hide
)
Description:
Bug 23357: (follow-up) Do not generate twice the same print notice
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2020-03-12 14:14:42 UTC
Size:
3.78 KB
patch
obsolete
>From 4d8b6ceab5fc10be4baa9dbfb181727c870691b9 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 12 Mar 2020 14:41:45 +0100 >Subject: [PATCH] Bug 23357: Do not generate twice the same print notice > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > misc/cronjobs/overdue_notices.pl | 41 ++++++++++++++++++++-------------------- > 1 file changed, 21 insertions(+), 20 deletions(-) > >diff --git a/misc/cronjobs/overdue_notices.pl b/misc/cronjobs/overdue_notices.pl >index a134a12ea9..acfe82a1c2 100755 >--- a/misc/cronjobs/overdue_notices.pl >+++ b/misc/cronjobs/overdue_notices.pl >@@ -742,26 +742,27 @@ END_SQL > ); > } else { > # Just send a print only if not already done. >- unless ( $effective_mtt eq 'print' and $print_sent == 1 ) { >- if ( ($mtt eq 'email' and not scalar @emails_to_use) or ($mtt eq 'sms' and not $data->{smsalertnumber}) ) { >- push @output_chunks, >- prepare_letter_for_printing( >- { letter => $letter, >- borrowernumber => $borrowernumber, >- firstname => $data->{'firstname'}, >- lastname => $data->{'surname'}, >- address1 => $data->{'address'}, >- address2 => $data->{'address2'}, >- city => $data->{'city'}, >- postcode => $data->{'zipcode'}, >- country => $data->{'country'}, >- email => $notice_email, >- itemcount => $itemcount, >- titles => $titles, >- outputformat => defined $csvfilename ? 'csv' : defined $htmlfilename ? 'html' : defined $text_filename ? 'text' : '', >- } >- ); >- } >+ if ( $effective_mtt eq 'print' and not $print_sent ) { >+ push @output_chunks, >+ prepare_letter_for_printing( >+ { letter => $letter, >+ borrowernumber => $borrowernumber, >+ firstname => $data->{'firstname'}, >+ lastname => $data->{'surname'}, >+ address1 => $data->{'address'}, >+ address2 => $data->{'address2'}, >+ city => $data->{'city'}, >+ postcode => $data->{'zipcode'}, >+ country => $data->{'country'}, >+ email => $notice_email, >+ itemcount => $itemcount, >+ titles => $titles, >+ outputformat => defined $csvfilename ? 'csv' : defined $htmlfilename ? 'html' : defined $text_filename ? 'text' : '', >+ } >+ ); >+ } >+ >+ if ( $effective_mtt ne 'print' or not $print_sent ) { > C4::Letters::EnqueueLetter( > { letter => $letter, > borrowernumber => $borrowernumber, >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23357
:
91693
|
100325
|
100634
| 100639