Attachment 100669 Details for Bug 24858 – Bug 24858: Correct labels on wording in ExcludeHolidaysFromMaxPickUpDelay

[patch] Bug 24858: Correct labels on wording in ExcludeHolidaysFromMaxPickUpDelay

Bug-24858-Correct-labels-on-wording-in-ExcludeHoli.patch (text/plain), 1.62 KB, created by David Nind on 2020-03-13 08:41:04 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2020-03-13 08:41:04 UTC

Size: 1.62 KB

patch

obsolete

>From bf9969ecdba352ec67440a7cabf4c0a6b5f8dee0 Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Thu, 12 Mar 2020 22:38:47 +0000
>Subject: [PATCH] Bug 24858: Correct labels on wording in
> ExcludeHolidaysFromMaxPickUpDelay
>
>TO TEST:
>- Apply patch
>- mark your library closed today and tomorrow
>- set ReservesMaxPickUpDelay to 1 day
>- set ExcludeHolidaysFromMaxPickUpDelay to "Ignore the calendar"
>- place hold, capture hold
>- hold expiration date is set to tomorrow (doesn't skip closed days)
>
>- Set ExcludeHolidaysFromMaxPickUpDelay to "Use the calendar"
>- Place hold, capture hold
>- hold expiration date is set to the day after tomorrow (skips closed days)
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> .../intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref  | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
>index bb71416d15..3134f23a63 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
>@@ -757,8 +757,8 @@ Circulation:
>         -
>             - pref: ExcludeHolidaysFromMaxPickUpDelay
>               choices:
>-                  yes: Ignore the calendar
>-                  no: Use the calendar
>+                  yes: Use the calendar
>+                  no: Ignore the calendar
>             - when calculating the period for reserves max pickup delay.
>         -
>             - pref: decreaseLoanHighHolds
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 24858: 100667 | 100669 | 100676