Attachment 100725 Details for Bug 23173 – Bug 23173: (follow-up) Allow for customisable display name

[patch] Bug 23173: (follow-up) Allow for customisable display name

Bug-23173-follow-up-Allow-for-customisable-display.patch (text/plain), 3.55 KB, created by Andrew Isherwood on 2020-03-16 09:15:42 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Andrew Isherwood

Created: 2020-03-16 09:15:42 UTC

Size: 3.55 KB

patch

obsolete

>From 6af6e3712a1e7b18cb65ec7271ada8430a12cc12 Mon Sep 17 00:00:00 2001
>From: Andrew Isherwood <andrew.isherwood@ptfs-europe.com>
>Date: Mon, 17 Feb 2020 12:29:19 +0000
>Subject: [PATCH] Bug 23173: (follow-up) Allow for customisable display name
>
>We now allow for the service to return a name that can be specified in
>the plugin config. This patch switches to using that, rather than just
>the plugin name defined in the plugin's metadata hashref
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/ill-availability-table.inc | 1 -
> koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt         | 4 ++--
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt        | 2 +-
> 3 files changed, 3 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/ill-availability-table.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/ill-availability-table.inc
>index 3cd00e709d..69e6679edc 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/ill-availability-table.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/ill-availability-table.inc
>@@ -1,5 +1,4 @@
> <div>
>-    <div>[% service.name %]</div>
>     <table class="ill-availability" id="[% service.id %]">
>         <thead id="[% service.id %]-header">
>             <tr>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
>index 27ccaf5ad9..c9fe65bcb5 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
>@@ -181,7 +181,7 @@
>                                         </div>
>                                         <div class="modal-body">
>                                             [% FOR service IN services %]
>-                                                <h4 class="ill_availability_sourcename">[% service.plugin %]</h4>
>+                                                <h4 class="ill_availability_sourcename">[% service.name %]</h4>
>                                                 [% INCLUDE 'ill-availability-table.inc' service=service %]
>                                             [% END %]
>                                             <span id="service_id_restrict" data-service_id_restrict_plugin="ILL availability - z39.50" data-service_id_restrict_ids=""></span>
>@@ -573,7 +573,7 @@
>                             </div>
>                         </form>
>                         [% FOR service IN services %]
>-                            <h4 class="ill_availability_sourcename">[% service.plugin %]</h4>
>+                            <h4 class="ill_availability_sourcename">[% service.name %]</h4>
>                             [% INCLUDE 'ill-availability-table.inc' service=service %]
>                         [% END %]
>                     </div>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt
>index a2b0571329..77fa2aaa22 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt
>@@ -251,7 +251,7 @@
>                                 </div>
>                             </form>
>                             [% FOR service IN services %]
>-                                <h4 class="ill_availability_sourcename">[% service.plugin %]</h4>
>+                                <h4 class="ill_availability_sourcename">[% service.name %]</h4>
>                                 [% INCLUDE 'ill-availability-table.inc' service=service %]
>                             [% END %]
>                         </div>
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 23173: 91464 | 91465 | 92107 | 92108 | 92539 | 92540 | 92550 | 92551 | 92640 | 92641 | 92693 | 92694 | 92695 | 92715 | 92716 | 92717 | 93146 | 93147 | 93148 | 93909 | 93910 | 93911 | 95268 | 95269 | 95270 | 98521 | 99083 | 100724 | 100725 | 100740 | 102179 | 102180 | 102181 | 102182 | 102183 | 102184 | 102286 | 102287 | 102288 | 102289 | 102290 | 102291 | 102292 | 102293 | 102294