Bugzilla – Attachment 10077 Details for
Bug 6679
Fixing code so it passes basic Perl::Critic tests
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED OFF] Bug 6679: Fixing 5 perlcritic violations in opac/*
SIGNED-OFF-Bug-6679-Fixing-5-perlcritic-violations.patch (text/plain), 2.91 KB, created by
Joy Nelson
on 2012-06-10 10:54:49 UTC
(
hide
)
Description:
[SIGNED OFF] Bug 6679: Fixing 5 perlcritic violations in opac/*
Filename:
MIME Type:
Creator:
Joy Nelson
Created:
2012-06-10 10:54:49 UTC
Size:
2.91 KB
patch
obsolete
>From 8acd8b8222b515280e9f8130c2a960cc93e495d1 Mon Sep 17 00:00:00 2001 >From: Mason James <mtj@kohaaloha.com> >Date: Thu, 24 May 2012 04:32:17 +1200 >Subject: [PATCH] [SIGNED OFF] Bug 6679: Fixing 5 perlcritic violations in opac/* > >1 more to go... :) > >opac/changelanguage.pl: Code before strictures are enabled at line 24, column 1. >See page 429 of PBP. (Severity: 5) > >Note: Rebased on master 06/09/2012 by jcamins >Signed-off-by: Joy Nelson <joy@bywatersolutions.com> >--- > opac/changelanguage.pl | 4 ++-- > opac/opac-detail.pl | 9 ++++++--- > opac/opac-reserve.pl | 2 +- > 3 files changed, 9 insertions(+), 6 deletions(-) > >diff --git a/opac/changelanguage.pl b/opac/changelanguage.pl >index 3d1c2a8..6095324 100755 >--- a/opac/changelanguage.pl >+++ b/opac/changelanguage.pl >@@ -15,8 +15,8 @@ > # with Koha; if not, write to the Free Software Foundation, Inc., > # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. > >-#use strict; >-#use warnings; FIXME - Bug 2505 >+use strict; >+use warnings; > > use C4::Templates; > use CGI; >diff --git a/opac/opac-detail.pl b/opac/opac-detail.pl >index 4a92d9a..eaad3e2 100755 >--- a/opac/opac-detail.pl >+++ b/opac/opac-detail.pl >@@ -143,8 +143,10 @@ if ($session->param('busc')) { > my @servers; > @servers = @{$arrParamsBusc->{'server'}} if $arrParamsBusc->{'server'}; > @servers = ("biblioserver") unless (@servers); >- my $default_sort_by = C4::Context->preference('OPACdefaultSortField')."_".C4::Context->preference('OPACdefaultSortOrder') if (C4::Context->preference('OPACdefaultSortField') && C4::Context->preference('OPACdefaultSortOrder')); >- my @sort_by = @{$arrParamsBusc->{'sort_by'}} if $arrParamsBusc->{'sort_by'}; >+ >+ my ($default_sort_by, @sort_by); >+ $default_sort_by = C4::Context->preference('OPACdefaultSortField')."_".C4::Context->preference('OPACdefaultSortOrder') if (C4::Context->preference('OPACdefaultSortField') && C4::Context->preference('OPACdefaultSortOrder')); >+ @sort_by = @{$arrParamsBusc->{'sort_by'}} if $arrParamsBusc->{'sort_by'}; > $sort_by[0] = $default_sort_by if !$sort_by[0] && defined($default_sort_by); > my ($error, $results_hashref, $facets); > eval { >@@ -420,7 +422,8 @@ my @items; > my @hiddenitems = GetHiddenItemnumbers(@all_items); > > # Are there items to hide? >-my $hideitems = 1 if C4::Context->preference('hidelostitems') or scalar(@hiddenitems) > 0; >+my $hideitems; >+$hideitems = 1 if C4::Context->preference('hidelostitems') or scalar(@hiddenitems) > 0; > > # Hide items > if ($hideitems) { >diff --git a/opac/opac-reserve.pl b/opac/opac-reserve.pl >index aae8314..1fb4df0 100755 >--- a/opac/opac-reserve.pl >+++ b/opac/opac-reserve.pl >@@ -57,7 +57,7 @@ for ( C4::Context->preference("OPACShowHoldQueueDetails") ) { > m/priority/ and $show_priority = 1; > } > >-sub get_out ($$$) { >+sub get_out { > output_html_with_http_headers(shift,shift,shift); # $query, $cookie, $template->output; > exit; > } >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 6679
:
4883
|
4884
|
4885
|
4886
|
4887
|
4888
|
5445
|
5446
|
5483
|
5487
|
6121
|
6122
|
6123
|
6139
|
6140
|
6141
|
6142
|
6143
|
6144
|
6270
|
6271
|
6663
|
6670
|
6675
|
6676
|
6677
|
6678
|
8542
|
8897
|
8898
|
8899
|
8950
|
8951
|
9746
|
9747
|
9748
|
9749
|
9750
|
10050
|
10051
|
10052
|
10053
|
10054
|
10075
|
10076
|
10077
|
10078
|
10079
|
10484
|
10485
|
10486
|
10487
|
10488
|
10489
|
10491
|
10492
|
10493
|
10494
|
10495
|
10496
|
10497
|
10499
|
10500
|
10501
|
10502
|
10503
|
10504
|
10505
|
10506
|
10507
|
10508
|
10509
|
10510
|
10512
|
10513
|
10514
|
10515
|
10517
|
10521
|
10522
|
10523
|
10524
|
10525
|
10526
|
10527
|
10935
|
10936
|
10938
|
10940
|
10944
|
10945
|
10946
|
10947
|
10948
|
10949
|
10950
|
10952
|
10953
|
10955
|
10957
|
10958
|
10959
|
10960
|
10961
|
10962
|
10963
|
10964
|
10965
|
10966
|
10967
|
10972
|
10976
|
10979
|
10980
|
10981
|
12224
|
12363
|
12490
|
12491
|
12492
|
34191
|
34192
|
34193
|
34194
|
34195
|
34196
|
34197
|
39100
|
39101
|
39102
|
39392
|
39393
|
39394
|
39395
|
39396
|
39397
|
39398
|
42770
|
47086
|
47087
|
47088
|
47089
|
47090
|
47178
|
47179
|
47180
|
47181
|
47205
|
47206
|
47207
|
47208