Bugzilla – Attachment 100804 Details for
Bug 23590
Add the ability to change the manager of a suggestion and notify the new manager
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23590: Create a separate template notice NOTIFY_MANAGER
Bug-23590-Create-a-separate-template-notice-NOTIFY.patch (text/plain), 4.40 KB, created by
Jonathan Druart
on 2020-03-16 17:50:34 UTC
(
hide
)
Description:
Bug 23590: Create a separate template notice NOTIFY_MANAGER
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2020-03-16 17:50:34 UTC
Size:
4.40 KB
patch
obsolete
>From e522b3137136c7f2502032eca04a786dda3a2dd6 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 16 Mar 2020 18:46:22 +0100 >Subject: [PATCH] Bug 23590: Create a separate template notice NOTIFY_MANAGER > >To separate the two feature we want to create a distinct template >notice. >A new NOTIFY_MANAGER notice is added. >A follow-up patch will be added for other languages, when this one will >be approved by QA. >--- > .../data/mysql/atomicupdate/bug_23590.perl | 5 +++++ > .../data/mysql/en/mandatory/sample_notices.yml | 17 +++++++++++++++++ > .../prog/en/modules/suggestion/suggestion.tt | 2 +- > suggestion/suggestion.pl | 2 +- > 4 files changed, 24 insertions(+), 2 deletions(-) > >diff --git a/installer/data/mysql/atomicupdate/bug_23590.perl b/installer/data/mysql/atomicupdate/bug_23590.perl >index cc80154a4a..9ca122086e 100644 >--- a/installer/data/mysql/atomicupdate/bug_23590.perl >+++ b/installer/data/mysql/atomicupdate/bug_23590.perl >@@ -35,8 +35,13 @@ if( CheckVersion( $DBversion ) ) { > WHERE suggestionid = ? > |, undef, $max_date, $last_modif_by, $suggestion->{suggestionid}); > } >+ > } > >+ $dbh->do( q| >+ INSERT IGNORE INTO letter(module, code, branchcode, name, is_html, title, content, message_transport_type, lang) VALUES ('suggestions', 'NOTIFY_MANAGER', '', 'Notify manager of a suggestion', 0, "A suggestion has been assigned to you", "Dear [% borrower.firstname %] [% borrower.surname %],\nA suggestion has been assigned to you: [% suggestion.title %].\nThank you,\n[% branch.branchname %]", 'email', 'default'); >+ | ); >+ > # Always end with this (adjust the bug info) > SetVersion( $DBversion ); > print "Upgrade to $DBversion done (Bug 23590 - Add lastmodificationby and lastmodificationdate to the suggestions table)\n"; >diff --git a/installer/data/mysql/en/mandatory/sample_notices.yml b/installer/data/mysql/en/mandatory/sample_notices.yml >index a2b7dec89b..a378e4d370 100644 >--- a/installer/data/mysql/en/mandatory/sample_notices.yml >+++ b/installer/data/mysql/en/mandatory/sample_notices.yml >@@ -1145,3 +1145,20 @@ tables: > - "Thank you," > - "" > - "<<branches.branchname>>" >+ >+ - module: suggestions >+ code: NOTIFY_MANAGER >+ branchcode: "" >+ name: "Notify manager of a suggestion" >+ is_html: 0 >+ title: "A suggestion has been assigned to you" >+ message_transport_type: email >+ lang: default >+ content: >+ - "Dear [% borrower.firstname %] [% borrowers.surname %]," >+ - "" >+ - "A new suggestion has been assigned to you: [% suggestion.title %]." >+ - "" >+ - "Thank you," >+ - "" >+ - "[% branch.branchname %]" >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >index 79c7649f3c..128a8fe255 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >@@ -418,7 +418,7 @@ > > <br/> > <label for="notify">Notify manager:</label> >- <input type="checkbox" id="notify" name="notify" value="notify" disabled="disabled" title="A TO_PROCESS notice will be generated and send to the manager if a valid email address is defined. This can be checked if a new manager has been selected." /> >+ <input type="checkbox" id="notify" name="notify" value="notify" disabled="disabled" title="A NOTIFY_MANAGER notice will be generated and send to the manager if a valid email address is defined. This can be checked if a new manager has been selected." /> > </div> > </li> > </ol> >diff --git a/suggestion/suggestion.pl b/suggestion/suggestion.pl >index 64d7610ea0..6a80310a92 100755 >--- a/suggestion/suggestion.pl >+++ b/suggestion/suggestion.pl >@@ -180,7 +180,7 @@ if ( $op =~ /save/i ) { > > my $letter = C4::Letters::GetPreparedLetter( > module => 'suggestions', >- letter_code => 'TO_PROCESS', >+ letter_code => 'NOTIFY_MANAGER', > branchcode => $patron->branchcode, > lang => $patron->lang, > tables => { >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23590
:
95162
|
95163
|
95164
|
95165
|
95166
|
95167
|
95168
|
95169
|
95317
|
95318
|
95319
|
95320
|
95321
|
95322
|
95323
|
95324
|
95398
|
95399
|
95407
|
95408
|
95420
|
95421
|
95422
|
95423
|
95424
|
95425
|
95426
|
95427
|
95428
|
95429
|
95430
|
95431
|
95487
|
95488
|
95489
|
95490
|
95491
|
95492
|
95493
|
95494
|
95495
|
95496
|
95497
|
95498
|
98119
|
98120
|
98121
|
98122
|
98123
|
98124
|
98126
|
98127
|
98128
|
98129
|
98130
|
98131
|
98240
|
98267
|
98268
|
98279
|
100788
|
100789
|
100790
|
100791
|
100792
|
100793
|
100794
|
100795
|
100796
|
100797
|
100798
|
100799
|
100800
|
100801
|
100802
|
100803
|
100804
|
100846
|
100847
|
100848
|
100849
|
100850
|
100851
|
100852
|
100853
|
101539
|
101548
|
101588
|
101589
|
101590
|
101591
|
101592
|
101593
|
101594
|
101595
|
101596
|
101597
|
101598
|
101599
|
101600
|
101601
|
101602
|
101603
|
101604
|
101605
|
101606
|
101695