Attachment 100930 Details for Bug 24495 – Bug 24495: Reword change collection feature

[patch] Bug 24495: Reword change collection feature

Bug-24495-Reword-change-collection-feature.patch (text/plain), 3.29 KB, created by Jonathan Druart on 2020-03-18 08:16:24 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2020-03-18 08:16:24 UTC

Size: 3.29 KB

patch

obsolete

>From cdbdd0703df0ee5ed6a17e0f5e262723589d8a8c Mon Sep 17 00:00:00 2001
>From: David Roberts <david@koha-ptfs.co.uk>
>Date: Tue, 28 Jan 2020 00:21:19 +0000
>Subject: [PATCH] Bug 24495: Reword change collection feature
>
>This patch changes the text of the "Collect from patron" field to read "Amount tendered"
>
>To Test:
>
>1) In the Point of Sale screen, check that the text inside the "Collect payment" box reads "Collect from patron"
>2) Go into a patron record, and create a manual invoice.
>3) Go to Make a payment, and select to "Pay an amount". Check the text reads "Collect from patron".
>4) Repeat the process with the "Pay Selected", and "Pay" button (listed next to the individual invoice)
>5) Install the patch
>6) Repeat steps 1-4, but the text should now read "Amount tendered", instead of "Collect from patron" in all payment options in the patron record, and in the Point of Sale screen.
>
>Signed-off-by: David Nind <david@davidnind.com>
>
>Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
>Signed-off-by: Bouzid Fergani <bouzid.fergani@inlibro.com>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt | 4 ++--
> koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt            | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt
>index 3d13d3a339..842f5e6003 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt
>@@ -121,7 +121,7 @@
>         <input name="paid" id="paid" type="text" step="0.01" value="[% amountoutstanding | $Price on_editing => 1 %]"/>
>     </li>
>     <li>
>-        <label for="collected">Collected from patron: </label>
>+        <label for="collected">Amount tendered: </label>
>         <input name="collected" id="collected" type="text" step="0.01" value="[% amountoutstanding | $Price on_editing => 1 %]"/>
>     </li>
>     <li>
>@@ -241,7 +241,7 @@
>     </li>
>     [% IF type != 'WRITEOFF' %]
>         <li>
>-            <label for="collected">Collected from patron: </label>
>+            <label for="collected">Amount tendered: </label>
>             <input name="collected" id="collected" type="text" step="0.01" value="[% total | $Price on_editing => 1 %]"/>
>         </li>
>         <li>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt
>index 2435d7176a..021e4ea611 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt
>@@ -103,7 +103,7 @@
>                                 <input type="number" min="0.00" max="10000.00" step="0.01" name="paid" id="paid" value="[% amountoutstanding | $Price on_editing => 1 %]" readonly/>
>                             </li>
>                             <li>
>-                                <label for="collected">Collected from patron: </label>
>+                                <label for="collected">Amount tendered: </label>
>                                 <input type="number" min="0.00" max="10000.00" step="0.01" name="collected" id="collected" value=""/>
>                             </li>
>                             <li>
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 24495: 98009 | 98010 | 98043 | 98595 | 100930