Bugzilla – Attachment 100946 Details for
Bug 24722
reserves.priority must be NOT NULL
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24722: reserves.priority must default to 1 at DB level
Bug-24722-reservespriority-must-default-to-1-at-DB.patch (text/plain), 3.08 KB, created by
Jonathan Druart
on 2020-03-18 10:10:31 UTC
(
hide
)
Description:
Bug 24722: reserves.priority must default to 1 at DB level
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2020-03-18 10:10:31 UTC
Size:
3.08 KB
patch
obsolete
>From 493f3441810514ace23500f345b3b9346190d5a6 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 18 Mar 2020 11:07:14 +0100 >Subject: [PATCH] Bug 24722: reserves.priority must default to 1 at DB level > >--- > installer/data/mysql/kohastructure.sql | 4 ++-- > installer/data/mysql/updatedatabase.pl | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > >diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql >index 9545b67cce..a7d756a6fd 100644 >--- a/installer/data/mysql/kohastructure.sql >+++ b/installer/data/mysql/kohastructure.sql >@@ -1757,7 +1757,7 @@ CREATE TABLE `reserves` ( -- information related to holds/reserves in Koha > `reminderdate` date default NULL, -- currently unused > `cancellationdate` date default NULL, -- the date this hold was cancelled > `reservenotes` LONGTEXT, -- notes related to this hold >- `priority` smallint(6) NOT NULL, -- where in the queue the patron sits >+ `priority` smallint(6) NOT NULL DEFAULT 1, -- where in the queue the patron sits > `found` varchar(1) default NULL, -- a one letter code defining what the status is of the hold is after it has been confirmed > `timestamp` timestamp NOT NULL default CURRENT_TIMESTAMP on update CURRENT_TIMESTAMP, -- the date and time this hold was last updated > `itemnumber` int(11) default NULL, -- foreign key from the items table defining the specific item the patron has placed on hold or the item this hold was filled with >@@ -1797,7 +1797,7 @@ CREATE TABLE `old_reserves` ( -- this table holds all holds/reserves that have b > `reminderdate` date default NULL, -- currently unused > `cancellationdate` date default NULL, -- the date this hold was cancelled > `reservenotes` LONGTEXT, -- notes related to this hold >- `priority` smallint(6) NOT NULL, -- where in the queue the patron sits >+ `priority` smallint(6) NOT NULL DEFAULT 1, -- where in the queue the patron sits > `found` varchar(1) default NULL, -- a one letter code defining what the status is of the hold is after it has been confirmed > `timestamp` timestamp NOT NULL default CURRENT_TIMESTAMP on update CURRENT_TIMESTAMP, -- the date and time this hold was last updated > `itemnumber` int(11) default NULL, -- foreign key from the items table defining the specific item the patron has placed on hold or the item this hold was filled with >diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl >index a26f409609..f511d84dab 100755 >--- a/installer/data/mysql/updatedatabase.pl >+++ b/installer/data/mysql/updatedatabase.pl >@@ -21109,7 +21109,7 @@ if( CheckVersion( $DBversion ) ) { > |); > > $dbh->do(q| >- ALTER TABLE reserves MODIFY priority SMALLINT(6) NOT NULL >+ ALTER TABLE reserves MODIFY priority SMALLINT(6) NOT NULL DEFAULT 1 > |); > > $dbh->do(q| >@@ -21117,7 +21117,7 @@ if( CheckVersion( $DBversion ) ) { > |); > > $dbh->do(q| >- ALTER TABLE old_reserves MODIFY priority SMALLINT(6) NOT NULL >+ ALTER TABLE old_reserves MODIFY priority SMALLINT(6) NOT NULL DEFAULT 1 > |); > > SetVersion( $DBversion ); >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24722
:
99572
|
99576
|
99577
|
99578
|
99595
|
99596
|
99597
|
99642
|
100822
|
100823
|
100824
|
100825
|
100860
|
100945
| 100946