Bugzilla – Attachment 100951 Details for
Bug 16787
'Too many holds' message appears inappropriately and is missing data
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16787: DBIC changes
Bug-16787-DBIC-changes.patch (text/plain), 4.02 KB, created by
Jonathan Druart
on 2020-03-18 10:46:08 UTC
(
hide
)
Description:
Bug 16787: DBIC changes
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2020-03-18 10:46:08 UTC
Size:
4.02 KB
patch
obsolete
>From a85f39076306a960f56f1680146fc91bb8bf5432 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 18 Mar 2020 11:45:53 +0100 >Subject: [PATCH] Bug 16787: DBIC changes > >--- > Koha/Schema/Result/ClubHoldsToPatronHold.pm | 7 ++++--- > Koha/Schema/Result/OldReserve.pm | 7 ++++--- > Koha/Schema/Result/Reserve.pm | 7 ++++--- > 3 files changed, 12 insertions(+), 9 deletions(-) > >diff --git a/Koha/Schema/Result/ClubHoldsToPatronHold.pm b/Koha/Schema/Result/ClubHoldsToPatronHold.pm >index 59ffca0daf..dfb3d13323 100644 >--- a/Koha/Schema/Result/ClubHoldsToPatronHold.pm >+++ b/Koha/Schema/Result/ClubHoldsToPatronHold.pm >@@ -50,7 +50,7 @@ __PACKAGE__->table("club_holds_to_patron_holds"); > =head2 error_code > > data_type: 'enum' >- extra: {list => ["damaged","ageRestricted","itemAlreadyOnHold","tooManyHoldsForThisRecord","tooManyReservesToday","tooManyReserves","notReservable","cannotReserveFromOtherBranches","libraryNotFound","libraryNotPickupLocation","cannotBeTransferred"]} >+ extra: {list => ["damaged","ageRestricted","itemAlreadyOnHold","tooManyHoldsForThisRecord","tooManyReservesToday","tooManyReserves","notReservable","cannotReserveFromOtherBranches","libraryNotFound","libraryNotPickupLocation","cannotBeTransferred","noReservesAllowed"]} > is_nullable: 1 > > =head2 error_message >@@ -86,6 +86,7 @@ __PACKAGE__->add_columns( > "libraryNotFound", > "libraryNotPickupLocation", > "cannotBeTransferred", >+ "noReservesAllowed", > ], > }, > is_nullable => 1, >@@ -159,8 +160,8 @@ __PACKAGE__->belongs_to( > ); > > >-# Created by DBIx::Class::Schema::Loader v0.07046 @ 2019-10-01 07:08:47 >-# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:/T626DfqUi7SnXOyieUzYw >+# Created by DBIx::Class::Schema::Loader v0.07046 @ 2020-03-18 10:45:06 >+# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:n4et0P1PDu4WrArtnl02hg > > sub koha_objects_class { > 'Koha::Club::Hold::PatronHolds'; >diff --git a/Koha/Schema/Result/OldReserve.pm b/Koha/Schema/Result/OldReserve.pm >index eb9033d06a..42f9f90bf4 100644 >--- a/Koha/Schema/Result/OldReserve.pm >+++ b/Koha/Schema/Result/OldReserve.pm >@@ -78,6 +78,7 @@ __PACKAGE__->table("old_reserves"); > =head2 priority > > data_type: 'smallint' >+ default_value: 1 > is_nullable: 0 > > =head2 found >@@ -165,7 +166,7 @@ __PACKAGE__->add_columns( > "reservenotes", > { data_type => "longtext", is_nullable => 1 }, > "priority", >- { data_type => "smallint", is_nullable => 0 }, >+ { data_type => "smallint", default_value => 1, is_nullable => 0 }, > "found", > { data_type => "varchar", is_nullable => 1, size => 1 }, > "timestamp", >@@ -297,8 +298,8 @@ __PACKAGE__->belongs_to( > ); > > >-# Created by DBIx::Class::Schema::Loader v0.07046 @ 2020-03-18 08:36:19 >-# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:RDZP4TEaFZUexg9jVg6DbA >+# Created by DBIx::Class::Schema::Loader v0.07046 @ 2020-03-18 10:45:06 >+# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:hqwQYNYrpsAAowBg3ImchA > > sub koha_object_class { > 'Koha::Old::Hold'; >diff --git a/Koha/Schema/Result/Reserve.pm b/Koha/Schema/Result/Reserve.pm >index 113b9e46de..9790b5386b 100644 >--- a/Koha/Schema/Result/Reserve.pm >+++ b/Koha/Schema/Result/Reserve.pm >@@ -82,6 +82,7 @@ __PACKAGE__->table("reserves"); > =head2 priority > > data_type: 'smallint' >+ default_value: 1 > is_nullable: 0 > > =head2 found >@@ -179,7 +180,7 @@ __PACKAGE__->add_columns( > "reservenotes", > { data_type => "longtext", is_nullable => 1 }, > "priority", >- { data_type => "smallint", is_nullable => 0 }, >+ { data_type => "smallint", default_value => 1, is_nullable => 0 }, > "found", > { data_type => "varchar", is_nullable => 1, size => 1 }, > "timestamp", >@@ -336,8 +337,8 @@ __PACKAGE__->belongs_to( > ); > > >-# Created by DBIx::Class::Schema::Loader v0.07046 @ 2020-02-25 11:25:52 >-# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:8f97w2B7OZT7KP+MKelI8g >+# Created by DBIx::Class::Schema::Loader v0.07046 @ 2020-03-18 10:45:06 >+# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:0UCAvY/ZiOsjg/vWYv5rJg > > __PACKAGE__->belongs_to( > "item", >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16787
:
52652
|
68894
|
68895
|
72827
|
72828
|
72889
|
91146
|
91147
|
91148
|
91149
|
96152
|
97403
|
99949
|
99950
|
100951
|
101473
|
101474
|
101475
|
101895
|
107793
|
107794
|
107795
|
114675
|
114676
|
114677
|
119279
|
119280
|
119281
|
119335
|
119336
|
119337
|
119616
|
119617
|
119619
|
119620
|
119621
|
119622
|
119623
|
119738
|
119739
|
119740
|
119741
|
119942
|
120009