Attachment 10110 Details for Bug 4460 – Bug 4460 - Amazon's AssociateID tag not used in links so referred revenue lost

[patch] Bug 4460 - Amazon's AssociateID tag not used in links so referred revenue lost

Bug-4460---Amazons-AssociateID-tag-not-used-in-lin.patch (text/plain), 11.50 KB, created by Jared Camins-Esakov on 2012-06-10 13:58:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jared Camins-Esakov

Created: 2012-06-10 13:58:36 UTC

Size: 11.50 KB

patch

obsolete

>From 32e7b17106cdccdaec3ae90835d7634041e87668 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Sat, 9 Jun 2012 09:18:00 -0400
>Subject: [PATCH] Bug 4460 - Amazon's AssociateID tag not used in links so referred revenue lost
>Content-Type: text/plain; charset="UTF-8"
>
>Rewrite of patch authored by Reed Wade <reed@catalyst.net.nz>
>
>Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
>---
> C4/Auth.pm                                         |    2 ++
> .../prog/en/modules/catalogue/detail.tt            |    4 ++--
> koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt |    2 +-
> .../prog/en/modules/opac-readingrecord.tt          |    3 +--
> koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt   |    4 ++--
> 5 files changed, 8 insertions(+), 7 deletions(-)
>
>diff --git a/C4/Auth.pm b/C4/Auth.pm
>index ffee1bb..878ebbd 100644
>--- a/C4/Auth.pm
>+++ b/C4/Auth.pm
>@@ -333,6 +333,7 @@ sub get_template_and_user {
>     if ( $in->{'type'} eq "intranet" ) {
>         $template->param(
>             AmazonContent               => C4::Context->preference("AmazonContent"),
>+            AmazonAssocTag              => C4::Context->preference("AmazonAssocTag"),
>             AmazonCoverImages           => C4::Context->preference("AmazonCoverImages"),
>             AmazonEnabled               => C4::Context->preference("AmazonEnabled"),
>             AmazonSimilarItems          => C4::Context->preference("AmazonSimilarItems"),
>@@ -396,6 +397,7 @@ sub get_template_and_user {
> 	}
>         $template->param(
>             AmazonContent             => "" . C4::Context->preference("AmazonContent"),
>+            AmazonAssocTag            => C4::Context->preference("AmazonAssocTag"),
>             AnonSuggestions           => "" . C4::Context->preference("AnonSuggestions"),
>             AuthorisedValueImages     => C4::Context->preference("AuthorisedValueImages"),
>             BranchesLoop              => GetBranchesLoop($opac_name),
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>index cd203c6..474915d 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>@@ -117,7 +117,7 @@ function verify_images() {
>         [% IF ( holdcount ) %]<span class="results_summary"><span class="label">Holds:</span> <span class="holdcount"><a href="/cgi-bin/koha/reserve/request.pl?biblionumber=[% biblionumber %]">[% holdcount %]</a></span></span>[% ELSE %][% END %]
> 
>         [% IF ( AmazonEnabled ) %][% IF ( AmazonCoverImages ) %]</div><div class="yui-u" id="bookcoverimg">
>-        <a href="http://www.amazon[% AmazonTld %]/gp/reader/[% normalized_isbn %]/ref=sib_dp_pt/002-7879865-0184864#reader-link"><img border="0" src="http://images.amazon.com/images/P/[% normalized_isbn %].01.MZZZZZZZ.jpg" alt="" /></a>[% END %][% END %]
>+        <a href="http://www.amazon[% AmazonTld %]/gp/reader/[% normalized_isbn %][% IF AmazonAssocTag %]?tag=[% AmazonAssocTag %][% END %]"><img border="0" src="http://images.amazon.com/images/P/[% normalized_isbn %].01.MZZZZZZZ.jpg" alt="" /></a></div>[% END %][% END %]
>     [% ELSE %]
> 
>     <h3>[% title |html %]</h3>
>@@ -521,7 +521,7 @@ function verify_images() {
> [% IF ( FRBRizeEditions ) %][% IF ( XISBNS ) %]
> <div id="editions"><h4>Editions</h4>
> <table>
>-[% FOREACH XISBN IN XISBNS %]<tr>[% IF ( XISBN.AmazonEnabled ) %]<td><a href="http://www.amazon.com/gp/reader/[% XISBN.normalized_isbn %]/ref=sib_dp_pt/002-7879865-0184864#reader-link"><img src="http://images.amazon.com/images/P/[% XISBN.normalized_isbn %].01._AA75_PU_PU-5_.jpg" /></a></td>[% END %]
>+[% FOREACH XISBN IN XISBNS %]<tr>[% IF ( XISBN.AmazonEnabled ) %]<td><a href="http://www.amazon.com/gp/reader/[% XISBN.normalized_isbn %][% IF XISBN.AmazonAssocTag %]?tag=[% XISBN.AmazonAssocTag %][% END %]"><img src="http://images.amazon.com/images/P/[% XISBN.normalized_isbn %].01._AA75_PU_PU-5_.jpg" /></a></td>[% END %]<td>[% IF noItemTypeImages %][% description %][% ELSE %]<img src="[% imageurl %]" alt="[% description %]" title="[% description %]">[% END %]</td><td>
> [% UNLESS ( item_level_itypes ) %]<td>[% IF ( noItemTypeImages ) %][% XISBN.description %][% ELSE %]<img src="[% XISBN.imageurl %]" alt="[% XISBN.description %]" title="[% XISBN.description %]">[% END %]</td>[% END %]
> <td><a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% XISBN.biblionumber %]">[% XISBN.title |html %]</a> by [% XISBN.author %] &copy;[% XISBN.copyrightdate %]
>   [% IF ( XISBN.publishercode ) %]
>diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt
>index 3c45aff..5488b79 100644
>--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt
>+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt
>@@ -296,7 +296,7 @@ YAHOO.util.Event.onContentReady("furtherm", function () {
> 
>     <div id="bookcover">
>     [% IF ( OPACLocalCoverImages ) %]<div style="block" title="[% biblionumber |url %]" class="[% biblionumber %]" id="local-thumbnail-preview"></div>[% END %]
>-    [% IF ( OPACAmazonEnabled ) %][% IF ( OPACAmazonCoverImages ) %][% IF ( OPACurlOpenInNewWindow ) %]<a href="http://www.amazon[% AmazonTld %]/gp/reader/[% normalized_isbn %]/ref=sib_dp_pt/002-7879865-0184864#reader-link" target="_blank"><img border="0" src="http://images.amazon.com/images/P/[% normalized_isbn %].01.MZZZZZZZ.jpg" alt="Cover image" /></a>[% ELSE %]<a href="http://www.amazon[% AmazonTld %]/gp/reader/[% normalized_isbn %]/ref=sib_dp_pt/002-7879865-0184864#reader-link"><img border="0" src="http://images.amazon.com/images/P/[% normalized_isbn %].01.MZZZZZZZ.jpg" alt="Cover image" /></a>[% END %][% END %][% END %]
>+    [% IF ( OPACAmazonEnabled ) %][% IF ( OPACAmazonCoverImages ) %][% IF ( OPACURLOpenInNewWindow ) %]<a href="http://www.amazon[% AmazonTld %]/gp/reader/[% normalized_isbn %][% IF AmazonAssocTag %]?tag=[% AmazonAssocTag %][% END %]" target="_blank"><img border="0" src="http://images.amazon.com/images/P/[% normalized_isbn %].01.MZZZZZZZ.jpg" alt="Cover Image" /></a>[% ELSE %]<a href="http://www.amazon[% AmazonTld %]/gp/reader/[% normalized_isbn %][% IF AmazonAssocTag %]?tag=[% AmazonAssocTag %][% END %]"><img border="0" src="http://images.amazon.com/images/P/[% normalized_isbn %].01.MZZZZZZZ.jpg" alt="Cover Image" /></a>[% END %][% END %][% END %]
> 
>     [% IF ( SyndeticsEnabled ) %][% IF ( SyndeticsCoverImages ) %][% IF ( content_identifier_exists ) %][% IF ( using_https ) %]
>     <img src="https://secure.syndetics.com/index.aspx?isbn=[% normalized_isbn %]/[% SyndeticsCoverImageSize %].GIF&amp;client=[% SyndeticsClientCode %]&amp;type=xw10&amp;upc=[% normalized_upc %]&amp;oclc=[% normalized_oclc %]" alt="" class="thumbnail" />
>diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-readingrecord.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-readingrecord.tt
>index 5f3f39c..b1fad84 100644
>--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-readingrecord.tt
>+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-readingrecord.tt
>@@ -65,8 +65,7 @@ You have never borrowed anything from this library.
> 
> [% UNLESS ( loop.odd ) %]<tr class="highlight">[% ELSE %]<tr>[% END %]
> <td>
>-[% IF ( OPACAmazonEnabled ) %][% IF ( OPACAmazonCoverImages ) %][% IF ( READING_RECOR.normalized_isbn ) %]<a href="http://www.amazon.com/gp/reader/[% READING_RECOR.normalized_isbn %]/ref=sib_dp_pt/002-7879865-0184864#reader-link"><img border="0" src="http://images.amazon.com/images/P/[% READING_RECOR.normalized_isbn %].01.THUMBZZZ.jpg" alt="Cover Image" /></a>[% ELSE %]<span class="no-image">No cover image available</span>[% END %][% END %][% END %]
>-
>+[% IF ( OPACAmazonEnabled ) %][% IF ( OPACAmazonCoverImages ) %][% IF ( READING>RECOR.normalized_isbn ) %]<a href="http://www.amazon.com/gp/reader/[% READING_RECOR.normalized_isbn %][% IF AmazonAssocTag %]?tag=[% AmazonAssocTag %][% END %]"><img border="0" src="http://images.amazon.com/images/P/[% READING_RECOR.normalized_isbn %].01.THUMBZZZ.jpg" alt="Cover Image" /></a>[% ELSE %]<span class="no-image">No cover image available</span>[% END %][% END %][% END %]
>     [% IF ( GoogleJackets ) %][% IF ( READING_RECOR.normalized_isbn ) %]<div style="block" title="[% READING_RECOR.biblionumber |url %]" class="[% READING_RECOR.normalized_isbn %]" id="gbs-thumbnail[% loop.count %]"></div>[% ELSE %]<span class="no-image">No cover image available</span>[% END %][% END %]
> 
>     [% IF ( BakerTaylorEnabled ) %][% IF ( READING_RECOR.normalized_isbn ) %]<a href="https://[% BakerTaylorBookstoreURL |html %][% READING_RECOR.normalized_isbn %]"><img alt="See Baker &amp; Taylor" src="[% BakerTaylorImageURL |html %][% READING_RECOR.normalized_isbn %]" /></a>[% ELSE %]<span class="no-image">No cover image available</span>[% END %][% END %]
>diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt
>index 6de2a81..e49b306 100644
>--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt
>+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt
>@@ -158,7 +158,7 @@ $.tablesorter.addParser({
> 
> [% IF ( JacketImages ) %]<td class="jacketcell">
> 
>-[% IF ( OPACAmazonCoverImages ) %][% IF ( ISSUE.normalized_isbn ) %]<a href="http://www.amazon.com/gp/reader/[% ISSUE.normalized_isbn %]/ref=sib_dp_pt/002-7879865-0184864#reader-link" title="View at Amazon.com"><img border="0" src="http://images.amazon.com/images/P/[% ISSUE.normalized_isbn %].01.THUMBZZZ.jpg" alt="Cover Image" /></a>[% ELSE %]<a href="#"><span class="no-image">No cover image available</span></a>[% END %][% END %]
>+[% IF ( OPACAmazonCoverImages ) %][% IF ( ISSUE.normalized_isbn ) %]<a href="http://www.amazon.com/gp/reader/[% ISSUE.normalized_isbn %][% IF AmazonAssocTag %]?tag=[% AmazonAssocTag %][% END %]" title="View at Amazon.com"><img border="0" src="http://images.amazon.com/images/P/[% ISSUE.normalized_isbn %].01.THUMBZZZ.jpg" alt="Cover Image" /></a>[% END %]<a href="#"><span class="no-image">No cover image available</span></a>[% END %][% END %]
> 
> [% IF ( GoogleJackets ) %][% IF ( ISSUE.normalized_isbn ) %]<div style="display:block;" title="Click to view in Google Books" class="[% ISSUE.normalized_isbn %]" id="gbs-thumbnail[% loop.count %]"></div>[% ELSE %]<a href="http://books.google.com/books?q=[% ISSUE.title |url %]"><span class="no-image">No cover image available</span></a>[% END %][% END %]
> 
>@@ -302,7 +302,7 @@ $.tablesorter.addParser({
> <tr>
> [% IF ( JacketImages ) %]<td class="jacketcell">
> 
>-[% IF ( OPACAmazonCoverImages ) %][% IF ( OVERDUE.normalized_isbn ) %]<a href="http://www.amazon.com/gp/reader/[% OVERDUE.normalized_isbn %]/ref=sib_dp_pt/002-7879865-0184864#reader-link" title="View at Amazon.com"><img src="http://images.amazon.com/images/P/[% OVERDUE.normalized_isbn %].01.THUMBZZZ.jpg" alt="" class="thumbnail" /></a>[% ELSE %]<a href="#"><span class="no-image">No cover image available</span></a>[% END %][% END %]
>+[% IF ( OPACAmazonCoverImages ) %][% IF ( ISSUE.normalized_isbn ) %]<a href="http://www.amazon.com/gp/reader/[% ISSUE.normalized_isbn %][% IF AmazonAssocTag %]?tag=[% AmazonAssocTag %][% END %]" title="View at Amazon.com"><img border="0" src="http://images.amazon.com/images/P/[% ISSUE.normalized_isbn %].01.THUMBZZZ.jpg" alt="Cover Image" /></a>[% END %]<a href="#"><span class="no-image">No cover image available</span></a>[% END %][% END %]
> 
> [% IF ( GoogleJackets ) %][% IF ( OVERDUE.normalized_isbn ) %]<div style="display:block;" title="Click to view in Google Books" class="[% OVERDUE.normalized_isbn %]" id="gbs-thumbnail[% loop.count %]"></div>[% ELSE %]<a href="http://books.google.com/books?q=[% OVERDUE.title |url %]"><span class="no-image">No cover image available</span></a>[% END %][% END %]
> 
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 4460: 2165 | 10024 | 10110 | 10600 | 10686 | 52670 | 54746 | 57688 | 60127 | 62921 | 62922 | 63328