Attachment 101101 Details for Bug 23808 – Bug 23808: (follow-up) Object methods can be used directly, no need for unblessed

[patch] Bug 23808: (follow-up) Object methods can be used directly, no need for unblessed

Bug-23808-follow-up-Object-methods-can-be-used-dir.patch (text/plain), 1.65 KB, created by Kyle M Hall (khall) on 2020-03-20 13:01:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2020-03-20 13:01:59 UTC

Size: 1.65 KB

patch

obsolete

>From cf5a8ef534fde4273279cd99750eae014a778836 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Fri, 20 Mar 2020 08:58:29 -0400
>Subject: [PATCH] Bug 23808: (follow-up) Object methods can be used directly,
> no need for unblessed
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> members/memberentry.pl | 18 +++++++++++-------
> 1 file changed, 11 insertions(+), 7 deletions(-)
>
>diff --git a/members/memberentry.pl b/members/memberentry.pl
>index 1e8241d985..ed482b9b81 100755
>--- a/members/memberentry.pl
>+++ b/members/memberentry.pl
>@@ -594,13 +594,17 @@ if (C4::Context->preference("IndependentBranches")) {
>     }
> }
> if ($op eq 'add'){
>-    if ( $guarantor_id ) {
>-        my $guarantordata = $guarantor->unblessed;
>-        foreach (qw(streetnumber address streettype address2
>-          zipcode country city state phone phonepro mobile fax email emailpro branchcode
>-          B_streetnumber B_streettype B_address B_address2
>-          B_city B_state B_zipcode B_country B_email B_phone)) {
>-              $newdata{$_} = $guarantordata->{$_};
>+    if ($guarantor_id) {
>+        foreach (
>+            qw(
>+                streetnumber address streettype address2 zipcode country city state phone phonepro mobile
>+                fax email emailpro branchcode
>+                B_streetnumber B_streettype B_address B_address2
>+                B_city B_state B_zipcode B_country B_email B_phone
>+            )
>+          )
>+        {
>+            $newdata{$_} = $guarantor->$_;
>         }
>     }
>     $template->param( updtype => 'I', step_1=>1, step_2=>1, step_3=>1, step_4=>1, step_5 => 1, step_6 => 1, step_7 => 1);
>-- 
>2.21.1 (Apple Git-122.3)

Actions: View | Diff | Splinter Review

Attachments on bug 23808: 100839 | 100840 | 100841 | 100842 | 100844 | 100845 | 100889 | 100900 | 100925 | 100928 | 100929 | 100957 | 100958 | 101098 | 101099 | 101100 | 101101 | 105565