Attachment 101106 Details for Bug 22025 – Bug 22025: Add a regression test

[patch] Bug 22025: Add a regression test

Bug-22025-Add-a-regression-test.patch (text/plain), 1.43 KB, created by Kyle M Hall (khall) on 2020-03-20 13:30:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2020-03-20 13:30:36 UTC

Size: 1.43 KB

patch

obsolete

>From d9989635e622d6e7208c3859a015656dc1715826 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Mon, 16 Mar 2020 15:43:38 +0100
>Subject: [PATCH] Bug 22025: Add a regression test
>
>Signed-off-by: Magnus Enger <magnus@libriotech.no>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> t/db_dependent/Koha/Patrons/Import.t | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
>diff --git a/t/db_dependent/Koha/Patrons/Import.t b/t/db_dependent/Koha/Patrons/Import.t
>index e908613cc7..ea3d1d83bf 100644
>--- a/t/db_dependent/Koha/Patrons/Import.t
>+++ b/t/db_dependent/Koha/Patrons/Import.t
>@@ -18,7 +18,7 @@
> # along with Koha; if not, see <http://www.gnu.org/licenses>.
> 
> use Modern::Perl;
>-use Test::More tests => 157;
>+use Test::More tests => 158;
> use Test::Warn;
> use Encode qw( encode_utf8 );
> use utf8;
>@@ -165,7 +165,10 @@ open(my $handle_3a, "<", $filename_3a) or die "cannot open < $filename_3: $!";
> my $params_3a = { file => $handle_3a, matchpoint => 'cardnumber', overwrite_cardnumber => 1};
> 
> # When ...
>-my $result_3a = $patrons_import->import_patrons($params_3a);
>+my $result_3a;
>+warning_is { $result_3a = $patrons_import->import_patrons($params_3a) }
>+           undef,
>+           "No warning raised by import_patrons";
> 
> # Then ...
> is($result_3a->{already_in_db}, 0, 'Got the expected 0 already_in_db from import_patrons when matched and overwrite set');
>-- 
>2.21.1 (Apple Git-122.3)

Actions: View | Diff | Splinter Review

Attachments on bug 22025: 100755 | 100756 | 100893 | 100894 | 101106 | 101107