Attachment 101110 Details for Bug 24848 – Bug 24848: Improve manual links for the label creator

[patch] Bug 24848: Improve manual links for the label creator

Bug-24848-Improve-manual-links-for-the-label-creat.patch (text/plain), 3.24 KB, created by Kyle M Hall (khall) on 2020-03-20 13:41:42 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2020-03-20 13:41:42 UTC

Size: 3.24 KB

patch

obsolete

>From a3bcdb0962877097a3a64a9cdeaef8ccba93ac8b Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <katrin.fischer.83@web.de>
>Date: Fri, 13 Mar 2020 17:40:38 +0000
>Subject: [PATCH] Bug 24848: Improve manual links for the label creator
>
>Some of the manual links in the label creator tool were
>not working correctly or pointing to the wrong pages.
>
>A problem is the label-manage.pl file. This can show
>different data depending on an added parameter. Example:
>/cgi-bin/koha/labels/label-manage.pl?label_element=template
>
>But it appears that parameters will be ignored when creating
>links to the manual. So this patch links to the beginning
>of the label creator section in the manual for now.
>
>To test:
>- Go to the lable creator
>- Try the various pages of the tool
>  - Note: All 'New ...' links should point to the
>    correct section in the manual (batches, templates, ...)
>    Except: Barcode range. This feature is new and not
>    yet documented in the manual. Link goes to label creator section.
>  - Note: All 'Manage ...' links should point to the
>    beginning of the 'label creator' section in the manual
>
>Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> Koha/Manual.pm | 16 +++++++---------
> 1 file changed, 7 insertions(+), 9 deletions(-)
>
>diff --git a/Koha/Manual.pm b/Koha/Manual.pm
>index 5037917601..966a723897 100644
>--- a/Koha/Manual.pm
>+++ b/Koha/Manual.pm
>@@ -131,15 +131,13 @@ our $mapping = {
>     'course_reserves/course-details'           => '/course_reserves.html',
>     'course_reserves/course-reserves'          => '/course_reserves.html',
>     'course_reserves/course'                   => '/course_reserves.html#adding-courses',
>-    'labels/label-edit-batch'                  => '/tools.html#batches',
>-    'labels/label-edit-layout'                 => '/tools.html#layouts',
>-    'labels/label-edit-profile'                => '/tools.html#profiles',
>-    'labels/label-edit-template'               => '/tools.html#templates',
>-    'labels/label-home'                        => '/tools.html#label-creator',
>-    'labels/label-manage'                      => '/tools.html#layouts',
>-    'labels/label-manage'                      => '/tools.html#templates',
>-    'labels/label-manage'                      => '/tools.html#profiles',
>-    'labels/label-manage'                      => '/tools.html#batches',
>+    'labels/label-edit-batch'                  => '/tools.html#label-batches-label',
>+    'labels/label-edit-layout'                 => '/tools.html#label-layouts-label',
>+    'labels/label-edit-profile'                => '/tools.html#label-profiles-label',
>+    'labels/label-edit-range'                  => '/tools.html#label-creator-label', #FIXME Add when documented
>+    'labels/label-edit-template'               => '/tools.html#label-templates-label',
>+    'labels/label-home'                        => '/tools.html#label-creator-label',
>+    'labels/label-manage'                      => '/tools.html#label-creator-label',
>     'labels/spinelabel-home'                   => '/tools.html#quick-spine-label-creator',
>     'mainpage'                                 => '/',
>     'members/apikeys'                          => '/webservices.html#api-key-management-interface-for-patrons',
>-- 
>2.21.1 (Apple Git-122.3)

Actions: View | Diff | Splinter Review

Attachments on bug 24848: 100714 | 100899 | 101108 | 101110