Bugzilla – Attachment 101112 Details for
Bug 24553
Cancelling hold via SIP returns a failed response even when cancellation succeeds
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24553: Use 'barcode' not 'item_id' when removing hold from SIP patron
Bug-24553-Use-barcode-not-itemid-when-removing-hol.patch (text/plain), 1.63 KB, created by
Marcel de Rooy
on 2020-03-20 13:42:12 UTC
(
hide
)
Description:
Bug 24553: Use 'barcode' not 'item_id' when removing hold from SIP patron
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2020-03-20 13:42:12 UTC
Size:
1.63 KB
patch
obsolete
>From 46fd848f5a73c6edff608ee09cfab3cb540007b0 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Tue, 25 Feb 2020 14:42:29 +0000 >Subject: [PATCH] Bug 24553: Use 'barcode' not 'item_id' when removing hold > from SIP patron >Content-Type: text/plain; charset=utf-8 > >The drop_hold routine was using the wrong parameter for item info in the patron's >array of holds. We store it as 'barcode' not 'item_id'. This is true for both waiting and unavailable >holds > >To test: >1 - Apply unit tests patch >2 - prove -v t/db_dependent/SIP/ILS.t >3 - It fails >4 - Apply second patch >5 - prove -v t/db_dependent/SIP/ILS.t >6 - It passes! > >You can also see bug 24175 - you cna hack sip_cli_emulator to allow cancelling a hold >and check the messages, test coverage is improved by this patch and should be sufficient >for testing > >Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > C4/SIP/ILS/Patron.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/SIP/ILS/Patron.pm b/C4/SIP/ILS/Patron.pm >index 4279b395d6..37c09386f5 100644 >--- a/C4/SIP/ILS/Patron.pm >+++ b/C4/SIP/ILS/Patron.pm >@@ -286,7 +286,7 @@ sub drop_hold { > foreach (qw(hold_items unavail_holds)) { > $self->{$_} or next; > for (my $i = 0; $i < scalar @{$self->{$_}}; $i++) { >- my $held_item = $self->{$_}[$i]->{item_id} or next; >+ my $held_item = $self->{$_}[$i]->{barcode} or next; > if ($held_item eq $item_id) { > splice @{$self->{$_}}, $i, 1; > $result++; >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24553
:
99592
|
99593
|
100891
|
100892
|
101095
|
101096
|
101111
| 101112 |
102518