Bugzilla – Attachment 101117 Details for
Bug 24688
Hold priority isn't adjusted correctly if checking out a middle priority hold
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24688: Check the priority of the fulfilled hold when fixing priorities
Bug-24688-Check-the-priority-of-the-fulfilled-hold.patch (text/plain), 1.81 KB, created by
Kyle M Hall (khall)
on 2020-03-20 14:22:22 UTC
(
hide
)
Description:
Bug 24688: Check the priority of the fulfilled hold when fixing priorities
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2020-03-20 14:22:22 UTC
Size:
1.81 KB
patch
obsolete
>From d080972773281e0324bb653a73328e017b343653 Mon Sep 17 00:00:00 2001 >From: Aleisha Amohia <aleishaamohia@hotmail.com> >Date: Thu, 20 Feb 2020 01:36:32 +0000 >Subject: [PATCH] Bug 24688: Check the priority of the fulfilled hold when > fixing priorities > >Currently when fixing priorities of existing holds, priorities aren't >fixed when checking out a middle priority hold because the hold has been >fulfilled and deleted. This patch adds a check for, if the hold can't be >found, an old hold with the required reserve_id. > >To test: >1. Place at least four holds on a biblio for different borrowers >2. Check out an item to the 3rd priority borrower >3. Check the existing holds table for the biblio. The priorities might be >out of order, or try clicking the dropdowns and there might be an empty >dropdown option, or open the browser developer tools and notice the option >values in the select are missing value=3. >4. Apply patch and restart memcached >5. Check out an item to the 2nd priority borrower >6. Check the existing holds table for the biblio. Confirm the priorities >have been fixed and are now consecutive with no gaps. > >Sponsored-by: Chartered Accountants Australia and New Zealand >Signed-off-by: Emmi Takkinen <emmi.takkinen@outlook.com> > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > C4/Reserves.pm | 4 ++++ > 1 file changed, 4 insertions(+) > >diff --git a/C4/Reserves.pm b/C4/Reserves.pm >index 27a9df7fad..c975d7f856 100644 >--- a/C4/Reserves.pm >+++ b/C4/Reserves.pm >@@ -1485,6 +1485,10 @@ sub _FixPriority { > my $hold; > if ( $reserve_id ) { > $hold = Koha::Holds->find( $reserve_id ); >+ if (!defined $hold){ >+ # may have already been checked out and hold fulfilled >+ $hold = Koha::Old::Holds->find( $reserve_id ); >+ } > return unless $hold; > } > >-- >2.21.1 (Apple Git-122.3)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24688
:
99291
|
100435
| 101117