Bugzilla – Attachment 101232 Details for
Bug 20443
Move C4::Members::Attributes to Koha namespace
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20443: Fix POD
Bug-20443-Fix-POD.patch (text/plain), 2.21 KB, created by
Jonathan Druart
on 2020-03-20 15:06:28 UTC
(
hide
)
Description:
Bug 20443: Fix POD
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2020-03-20 15:06:28 UTC
Size:
2.21 KB
patch
obsolete
>From a4a8f0466c3ef1212f2926f71d5a96080feab6c9 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 21 Jan 2020 13:03:56 +0100 >Subject: [PATCH] Bug 20443: Fix POD > >Fixes the following failures: > > FAIL Koha/Patron/Attribute.pm > FAIL pod > *** ERROR: > empty =head3 > > in file Koha/Patron/Attribute.pm > > *** ERROR: > empty =head3 > > in file Koha/Patron/Attribute.pm > > FAIL Koha/Patron/Attributes.pm > FAIL pod > *** ERROR: > empty =head3 > > in file Koha/Patron/Attributes.pm > > FAIL pod coverage > POD is missing for merge_with > POD is missing for object_class > > FAIL Koha/Patrons.pm > FAIL spelling > paramter ==> parameter > >except the missing pod for object_class, not needed. > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > Koha/Patron/Attribute.pm | 4 ++-- > Koha/Patron/Attributes.pm | 2 +- > Koha/Patrons.pm | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) > >diff --git a/Koha/Patron/Attribute.pm b/Koha/Patron/Attribute.pm >index 8d781b77b1..9118a7f812 100644 >--- a/Koha/Patron/Attribute.pm >+++ b/Koha/Patron/Attribute.pm >@@ -67,7 +67,7 @@ sub type { > return scalar Koha::Patron::Attribute::Types->find( $self->code ); > } > >-=head3 >+=head3 authorised_value > > my $authorised_value = $attribute->authorised_value; > >@@ -92,7 +92,7 @@ sub authorised_value { > return $av->next; > } > >-=head3 >+=head3 description > > my $description = $patron_attribute->description; > >diff --git a/Koha/Patron/Attributes.pm b/Koha/Patron/Attributes.pm >index 84685d9dc5..0e03c32972 100644 >--- a/Koha/Patron/Attributes.pm >+++ b/Koha/Patron/Attributes.pm >@@ -87,7 +87,7 @@ sub filter_by_branch_limitations { > return $self->search( $or, $join ); > } > >-=head3 >+=head3 merge_with > > $new_attributes is an arrayref of hashrefs > >diff --git a/Koha/Patrons.pm b/Koha/Patrons.pm >index 0b65756945..6943018e88 100644 >--- a/Koha/Patrons.pm >+++ b/Koha/Patrons.pm >@@ -446,7 +446,7 @@ sub filter_by_attribute_type { > > my $patrons = Koha::Patrons->filter_by_attribute_value($attribute_value); > >-Return a Koha::Patrons set with patrong having the attribute value passed in paramter. >+Return a Koha::Patrons set with patrong having the attribute value passed in parameter. > > =cut > >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20443
:
101122
|
101123
|
101124
|
101125
|
101126
|
101127
|
101128
|
101129
|
101130
|
101131
|
101132
|
101133
|
101134
|
101135
|
101136
|
101137
|
101138
|
101139
|
101140
|
101141
|
101142
|
101143
|
101144
|
101145
|
101146
|
101147
|
101148
|
101149
|
101150
|
101209
|
101210
|
101211
|
101212
|
101213
|
101214
|
101215
|
101216
|
101217
|
101218
|
101219
|
101220
|
101221
|
101222
|
101223
|
101224
|
101225
|
101226
|
101227
|
101228
|
101229
|
101230
|
101231
| 101232 |
101233
|
101234
|
101235
|
101236
|
101237
|
101472
|
104519