Bugzilla – Attachment 101238 Details for
Bug 24759
OpacRenewalBranch code should be a Koha::Item method
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24759: (follow-up) Fix tests
Bug-24759-follow-up-Fix-tests.patch (text/plain), 1.13 KB, created by
Nick Clemens (kidclamp)
on 2020-03-20 15:08:13 UTC
(
hide
)
Description:
Bug 24759: (follow-up) Fix tests
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2020-03-20 15:08:13 UTC
Size:
1.13 KB
patch
obsolete
>From 5cbffcd94f04031c3909cb9b4587cd82435ac22a Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Fri, 20 Mar 2020 15:07:27 +0000 >Subject: [PATCH] Bug 24759: (follow-up) Fix tests > >Earlier tests delete borrowers before issues, can cause a constraint failure > >Wrong test count >--- > t/db_dependent/Koha/Item.t | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/Koha/Item.t b/t/db_dependent/Koha/Item.t >index eac8ad6ec3..c42d8968bc 100644 >--- a/t/db_dependent/Koha/Item.t >+++ b/t/db_dependent/Koha/Item.t >@@ -153,10 +153,10 @@ subtest 'pickup_locations' => sub { > > # Cleanup database > Koha::Holds->search->delete; >+ $dbh->do('DELETE FROM issues'); > Koha::Patrons->search->delete; > Koha::Items->search->delete; > Koha::Libraries->search->delete; >- $dbh->do('DELETE FROM issues'); > Koha::CirculationRules->search->delete; > Koha::CirculationRules->set_rules( > { >@@ -331,7 +331,7 @@ subtest 'pickup_locations' => sub { > }; > > subtest 'renewal_branchcode' => sub { >- plan tests => 15; >+ plan tests => 13; > > $schema->storage->txn_begin; > >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24759
:
99763
|
99764
|
99780
|
99953
|
100002
|
100003
|
101238
|
101239
|
101240
|
101241
|
101242
|
101243
|
101244
|
101245
|
101285
|
101286
|
101287
|
101288
|
101289
|
101290
|
101291