Bugzilla – Attachment 101255 Details for
Bug 23463
Move C4::Items CRUD subroutines to Koha::Item
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23463: Move plugin hook
Bug-23463-Move-plugin-hook.patch (text/plain), 3.14 KB, created by
Jonathan Druart
on 2020-03-20 15:13:20 UTC
(
hide
)
Description:
Bug 23463: Move plugin hook
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2020-03-20 15:13:20 UTC
Size:
3.14 KB
patch
obsolete
>From 3c78af428ce0a5662140b640259544c0f79d2370 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 6 Aug 2019 10:17:28 -0500 >Subject: [PATCH] Bug 23463: Move plugin hook > >From C4::Items to Koha::Item > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > C4/Items.pm | 34 ---------------------------------- > Koha/Item.pm | 34 +++++++++++++++++++++++++++++++++- > 2 files changed, 33 insertions(+), 35 deletions(-) > >diff --git a/C4/Items.pm b/C4/Items.pm >index a5d9d85534..7031f63f13 100644 >--- a/C4/Items.pm >+++ b/C4/Items.pm >@@ -2526,38 +2526,4 @@ sub ToggleNewStatus { > return $report; > } > >-=head2 _after_item_action_hooks >- >-Helper method that takes care of calling all plugin hooks >- >-=cut >- >-sub _after_item_action_hooks { >- my ( $args ) = @_; >- >- my $item_id = $args->{item_id}; >- my $action = $args->{action}; >- >- if ( C4::Context->preference('UseKohaPlugins') && C4::Context->config("enable_plugins") ) { >- >- my @plugins = Koha::Plugins->new->GetPlugins({ >- method => 'after_item_action', >- }); >- >- if (@plugins) { >- >- my $item = Koha::Items->find( $item_id ); >- >- foreach my $plugin ( @plugins ) { >- try { >- $plugin->after_item_action({ action => $action, item => $item, item_id => $item_id }); >- } >- catch { >- warn "$_"; >- }; >- } >- } >- } >-} >- > 1; >diff --git a/Koha/Item.pm b/Koha/Item.pm >index a38385e062..db79cb6100 100644 >--- a/Koha/Item.pm >+++ b/Koha/Item.pm >@@ -22,6 +22,7 @@ use Modern::Perl; > use Carp; > use List::MoreUtils qw(any); > use Data::Dumper; >+use Try::Tiny; > > use Koha::Database; > use Koha::DateUtils qw( dt_from_string ); >@@ -38,6 +39,7 @@ use Koha::CirculationRules; > use Koha::Item::Transfer::Limits; > use Koha::Item::Transfers; > use Koha::Patrons; >+use Koha::Plugins; > use Koha::Libraries; > use Koha::StockRotationItem; > use Koha::StockRotationRotas; >@@ -145,7 +147,6 @@ sub store { > > logaction( "CATALOGUING", "MODIFY", $self->itemnumber, "item " . Dumper($self->unblessed) ) > if $log_action && C4::Context->preference("CataloguingLog"); >- > } > > unless ( $self->dateaccessioned ) { >@@ -655,6 +656,37 @@ sub to_api_mapping { > > =head2 Internal methods > >+=head3 _after_item_action_hooks >+ >+Helper method that takes care of calling all plugin hooks >+ >+=cut >+ >+sub _after_item_action_hooks { >+ my ( $self, $params ) = @_; >+ >+ my $action = $params->{action}; >+ >+ if ( C4::Context->preference('UseKohaPlugins') && C4::Context->config("enable_plugins") ) { >+ >+ my @plugins = Koha::Plugins->new->GetPlugins({ >+ method => 'after_item_action', >+ }); >+ >+ if (@plugins) { >+ >+ foreach my $plugin ( @plugins ) { >+ try { >+ $plugin->after_item_action({ action => $action, item => $self, item_id => $self->itemnumber }); >+ } >+ catch { >+ warn "$_"; >+ }; >+ } >+ } >+ } >+} >+ > =head3 _type > > =cut >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23463
:
95899
|
95900
|
95901
|
95902
|
95903
|
95904
|
95905
|
95906
|
95907
|
95908
|
95909
|
95910
|
95911
|
95912
|
95913
|
95914
|
95915
|
95916
|
95917
|
95918
|
95919
|
95920
|
95921
|
95922
|
95923
|
95925
|
96145
|
97895
|
97896
|
97897
|
97898
|
97899
|
97900
|
97901
|
97902
|
97903
|
97904
|
97905
|
97906
|
97907
|
97908
|
97909
|
97910
|
97911
|
97912
|
97913
|
97914
|
97915
|
97916
|
97917
|
97918
|
97919
|
97920
|
97921
|
101151
|
101152
|
101153
|
101154
|
101156
|
101157
|
101158
|
101161
|
101163
|
101165
|
101167
|
101169
|
101170
|
101171
|
101172
|
101173
|
101174
|
101175
|
101176
|
101177
|
101178
|
101179
|
101180
|
101181
|
101182
|
101183
|
101184
|
101185
|
101186
|
101188
|
101189
|
101190
|
101191
|
101192
|
101193
|
101194
|
101195
|
101196
|
101197
|
101246
|
101247
|
101248
|
101249
|
101250
|
101251
|
101252
|
101253
|
101254
| 101255 |
101256
|
101257
|
101258
|
101259
|
101260
|
101261
|
101262
|
101263
|
101264
|
101265
|
101266
|
101267
|
101268
|
101269
|
101270
|
101271
|
101272
|
101273
|
101274
|
101275
|
101276
|
101277
|
101278
|
101279
|
101280
|
101281
|
101282
|
101283
|
101284
|
101413
|
101414
|
101415
|
101416
|
101432
|
101476
|
102071
|
103129
|
113581