Bugzilla – Attachment 101280 Details for
Bug 23463
Move C4::Items CRUD subroutines to Koha::Item
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23463: Fix XSLT.t
Bug-23463-Fix-XSLTt.patch (text/plain), 1.62 KB, created by
Jonathan Druart
on 2020-03-20 15:14:59 UTC
(
hide
)
Description:
Bug 23463: Fix XSLT.t
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2020-03-20 15:14:59 UTC
Size:
1.62 KB
patch
obsolete
>From 8d59fbf97ba330fd0ffe341fcd2f9d604cae65ec Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 6 Mar 2020 10:40:29 +0100 >Subject: [PATCH] Bug 23463: Fix XSLT.t > >From commit bf49eecdd87e2b29760226281ab1afc0a185c7f0 > Bug 23463: Replace AddItem calls with Koha::Item->store > >in build_sample_item: >- my $itype = delete $args->{itype} >- || $self->build_object( { class => 'Koha::ItemTypes' } )->itemtype; >+ # If itype is not passed it will be picked from the biblio (see Koha::Item->store) > >So before we generated a new itemtype if not passed, now we pick the one from biblioitem->itemtype. > >For this specific test we need to make sure they are different. > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > t/db_dependent/XSLT.t | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > >diff --git a/t/db_dependent/XSLT.t b/t/db_dependent/XSLT.t >index e8fa2190cb..2d9e9db1b3 100644 >--- a/t/db_dependent/XSLT.t >+++ b/t/db_dependent/XSLT.t >@@ -35,7 +35,10 @@ $schema->storage->txn_begin; > > subtest 'buildKohaItemsNamespace status tests' => sub { > plan tests => 13; >- my $item = $builder->build_sample_item({}); >+ my $itype = $builder->build_object({ class => 'Koha::ItemTypes' }); >+ my $itemtype = $builder->build_object({ class => 'Koha::ItemTypes' }); >+ my $item = $builder->build_sample_item({ itype => $itype->itemtype }); >+ $item->biblioitem->itemtype($itemtype->itemtype)->store; > > my $xml = C4::XSLT::buildKohaItemsNamespace( $item->biblionumber,[]); > like($xml,qr{<status>available</status>},"Item is available when no other status applied"); >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23463
:
95899
|
95900
|
95901
|
95902
|
95903
|
95904
|
95905
|
95906
|
95907
|
95908
|
95909
|
95910
|
95911
|
95912
|
95913
|
95914
|
95915
|
95916
|
95917
|
95918
|
95919
|
95920
|
95921
|
95922
|
95923
|
95925
|
96145
|
97895
|
97896
|
97897
|
97898
|
97899
|
97900
|
97901
|
97902
|
97903
|
97904
|
97905
|
97906
|
97907
|
97908
|
97909
|
97910
|
97911
|
97912
|
97913
|
97914
|
97915
|
97916
|
97917
|
97918
|
97919
|
97920
|
97921
|
101151
|
101152
|
101153
|
101154
|
101156
|
101157
|
101158
|
101161
|
101163
|
101165
|
101167
|
101169
|
101170
|
101171
|
101172
|
101173
|
101174
|
101175
|
101176
|
101177
|
101178
|
101179
|
101180
|
101181
|
101182
|
101183
|
101184
|
101185
|
101186
|
101188
|
101189
|
101190
|
101191
|
101192
|
101193
|
101194
|
101195
|
101196
|
101197
|
101246
|
101247
|
101248
|
101249
|
101250
|
101251
|
101252
|
101253
|
101254
|
101255
|
101256
|
101257
|
101258
|
101259
|
101260
|
101261
|
101262
|
101263
|
101264
|
101265
|
101266
|
101267
|
101268
|
101269
|
101270
|
101271
|
101272
|
101273
|
101274
|
101275
|
101276
|
101277
|
101278
|
101279
| 101280 |
101281
|
101282
|
101283
|
101284
|
101413
|
101414
|
101415
|
101416
|
101432
|
101476
|
102071
|
103129
|
113581