Attachment 101326 Details for Bug 21503 – Bug 21503: Tests clarification for debugging

[patch] Bug 21503: Tests clarification for debugging

Bug-21503-Tests-clarification-for-debugging.patch (text/plain), 2.40 KB, created by Fridolin Somers on 2020-03-21 11:17:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Fridolin Somers

Created: 2020-03-21 11:17:52 UTC

Size: 2.40 KB

patch

obsolete

>From 50123519ad2f22b4a2b8da163637a941e1cdbc59 Mon Sep 17 00:00:00 2001
>From: Koha instance kohadev-koha <kohadev-koha@kohadevbox>
>Date: Wed, 17 Oct 2018 21:15:36 +0000
>Subject: [PATCH] Bug 21503: Tests clarification for debugging
>
>Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
>---
> t/db_dependent/Template/Plugin/AuthorisedValues.t | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/t/db_dependent/Template/Plugin/AuthorisedValues.t b/t/db_dependent/Template/Plugin/AuthorisedValues.t
>index ee27539dae..8d2382536b 100644
>--- a/t/db_dependent/Template/Plugin/AuthorisedValues.t
>+++ b/t/db_dependent/Template/Plugin/AuthorisedValues.t
>@@ -124,16 +124,16 @@ subtest 'GetDescriptionByKohaField' => sub {
>     # Opac display
>     my $av = Koha::Template::Plugin::AuthorisedValues->GetDescriptionByKohaField(
>         { opac => 1, kohafield => 'dummy.field', authorised_value => $av_1->authorised_value } );
>-    is( $av, 'lib_opac', 'The OPAC description should be displayed if exists' );
>+    is( $av, 'lib_opac', 'For OPAC: The OPAC description should be displayed if exists' );
>     $av = Koha::Template::Plugin::AuthorisedValues->GetDescriptionByKohaField(
>         { opac => 1, kohafield => 'dummy.field', authorised_value => $av_2->authorised_value } );
>-    is( $av, 'lib', 'The staff description should be displayed if none exists for OPAC' );
>+    is( $av, 'lib', 'For OPAC: The staff description should be displayed if none exists for OPAC' );
>     $av = Koha::Template::Plugin::AuthorisedValues->GetDescriptionByKohaField(
>         { opac => 1, kohafield => 'dummy.field', authorised_value => $av_3->authorised_value } );
>-    is( $av, $av_3->authorised_value, 'If both OPAC and staff descriptions are missing, the code should be displayed');
>+    is( $av, $av_3->authorised_value, 'For OPAC: If both OPAC and staff descriptions are missing, the code should be displayed');
>     $av = Koha::Template::Plugin::AuthorisedValues->GetDescriptionByKohaField(
>         { opac => 1, kohafield => 'dummy.field', authorised_value => $non_existent_av } );
>-    is( $av, $non_existent_av, 'If both OPAC and staff descriptions are missing, the parameter should be displayed');
>+    is( $av, $non_existent_av, 'For OPAC: If both OPAC and staff descriptions are missing, the parameter should be displayed');
> 
>     # Staff display
>     $av = Koha::Template::Plugin::AuthorisedValues->GetDescriptionByKohaField(
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 21503: 80151 | 80152 | 80233 | 80439 | 80521 | 80544 | 80545 | 80558 | 80561 | 80562 | 80563 | 80601 | 80758 | 80759 | 80762 | 101323 | 101324 | 101325 | 101326 | 101327 | 101328 | 101524 | 101525 | 101526 | 101527 | 101528 | 101529 | 101533 | 101534 | 101535