Attachment 101376 Details for Bug 22098 – Bug 22098: (QA follow-up) Improving documentation

[patch] Bug 22098: (QA follow-up) Improving documentation

Bug-22098-QA-follow-up-Improving-documentation.patch (text/plain), 2.17 KB, created by Katrin Fischer on 2020-03-22 14:10:15 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2020-03-22 14:10:15 UTC

Size: 2.17 KB

patch

obsolete

>From 70fd3d384c9be4ab4af1f3b24d03e74b34be9f3e Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <katrin.fischer.83@web.de>
>Date: Sun, 22 Mar 2020 15:06:35 +0100
>Subject: [PATCH] Bug 22098: (QA follow-up) Improving documentation
>
>Improves the documentation of the script a bit, but makes one
>important change:
>
>-If no prefix is submitted, or prefix does not contain only
>-numbers, it returns the inserted code (= keep a field unchanged)
>+If no prefix is submitted, or the prefix does contain only
>+numbers, it returns the inserted code (= keep the field unchanged).
>
>To test:
>- Add an authorised INVENTORY value with 2020 as prefix
>- After linking the stocknumberAV.pl to the 952$i in the frameworks
>- Edit an item
>- Add 2020 in the stocknumber field
>- Trigger plugin
>- Verify nothing happens
>
>If the prefix contains only numbers... nothing happens.
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> cataloguing/value_builder/stocknumberAV.pl | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
>diff --git a/cataloguing/value_builder/stocknumberAV.pl b/cataloguing/value_builder/stocknumberAV.pl
>index 3bf94da232..f0e35d484b 100755
>--- a/cataloguing/value_builder/stocknumberAV.pl
>+++ b/cataloguing/value_builder/stocknumberAV.pl
>@@ -28,18 +28,18 @@ use Koha::AuthorisedValues;
> 
> =head1 DESCRIPTION
> 
>-This plugin is based on authorised values INVENTORY.
>+This plugin is based on authorised values from INVENTORY.
> It is used for stocknumber computation.
> 
>-If no prefix is submitted, or prefix does not contain only
>-numbers, it returns the inserted code (= keep a field unchanged)
>+If no prefix is submitted, or the prefix does contain only
>+numbers, it returns the inserted code (= keep the field unchanged).
> 
>-If a prefix is submited, we look for the highest stocknumber
>-with this prefix, and return it incremented.
>+If a prefix is submitted, we look for the highest stocknumber
>+with this prefix and return it incremented.
> 
> In this case, a stocknumber has this form (e.g. "PREFIX 0009678570"):
>-PREFIX containing letters, a space separator, and
>-10 digits with leading 0s if needed
>+PREFIX containing letters, a space separator and 10 digits with leading
>+0s if needed.
> 
> =cut
> 
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 22098: 83776 | 91421 | 101329 | 101330 | 101373 | 101374 | 101375 | 101376