Attachment 101411 Details for Bug 24464 – Bug 24464: (QA follow-up) Make the method reflect the lack of FK

[patch] Bug 24464: (QA follow-up) Make the method reflect the lack of FK

Bug-24464-QA-follow-up-Make-the-method-reflect-the.patch (text/plain), 1.19 KB, created by Jonathan Druart on 2020-03-23 09:55:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2020-03-23 09:55:47 UTC

Size: 1.19 KB

patch

obsolete

>From bffce78ca646c24bfddb0aa2186ebeb50f93d31b Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Fri, 20 Mar 2020 15:53:35 -0300
>Subject: [PATCH] Bug 24464: (QA follow-up) Make the method reflect the lack of
> FK
>
>This patch makes it super obvious to understand by reading the code that
>there's originally no foreign key.
>
>To test:
>1. Run the tests and notice they pass
>2. Spot the # FIXME
>3. Sign off :-D
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> Koha/Acquisition/Basket.pm | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/Koha/Acquisition/Basket.pm b/Koha/Acquisition/Basket.pm
>index 4d9a87c3cd..65d9e16d5e 100644
>--- a/Koha/Acquisition/Basket.pm
>+++ b/Koha/Acquisition/Basket.pm
>@@ -57,8 +57,9 @@ Returns the I<Koha::Patron> for the basket creator.
> 
> sub creator {
>     my ($self) = @_;
>-    return Koha::Patrons->find( $self->authorisedby )
>-        if $self->authorisedby;
>+    my $borrowernumber = $self->authorisedby; # FIXME missing FK here
>+    return unless $borrowernumber;
>+    return Koha::Patrons->find( $borrowernumber );
> }
> 
> =head3 basket_group
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 24464: 97631 | 97632 | 98272 | 98275 | 98276 | 101316 | 101317 | 101409 | 101410 | 101411