Attachment 101495 Details for Bug 24959 – Bug 24959: Fix id/label pairs in saved reports table

[patch] Bug 24959: Fix id/label pairs in saved reports table

Bug-24959-Fix-idlabel-pairs-in-saved-reports-table.patch (text/plain), 2.52 KB, created by Owen Leonard on 2020-03-23 20:15:24 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2020-03-23 20:15:24 UTC

Size: 2.52 KB

patch

obsolete

>From f5aea2a5ef5775bfe24a1593195c1527da14eac0 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Mon, 23 Mar 2020 20:10:15 +0000
>Subject: [PATCH] Bug 24959: Fix id/label pairs in saved reports table
>
>This patch adds a unique id attribute to each checkbox in the table of
>saved reports. Also updated is the corresponding <label>'s "for"
>attribute so that clicking the report id will toggle the checkbox.
>
>To reproduce, go to Reports -> Use saved and click a number in the ID
>column. Nothing happens.
>
>After applying the patch clicking the number should check or uncheck the
>corresponding checkbox.
>---
> .../intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt     | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>index 26b9e6a3f4..7440fd29e0 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>@@ -249,12 +249,12 @@
>                                                 [% UNLESS ( loop.odd ) %]<tr class="odd">[% ELSE %]<tr>[% END %]
>                                                     <td class="report_checkbox">
>                                                         [% IF ( CAN_user_reports_delete_reports ) %] 
>-                                                            <input type="checkbox" name="ids" value="[% savedreport.id | html %]" />
>+                                                            <input type="checkbox" name="ids" id="ids[% savedreport.id | html %]" value="[% savedreport.id | html %]" />
>                                                         [% END %]
>                                                         <input type="hidden" class="report_sql" value="[% savedreport.savedsql |html %]">
>                                                     </td>
>                                                     <td class="report_id">
>-                                                        <label for="ids">[% savedreport.id | html %]</label>
>+                                                        <label for="ids[% savedreport.id | html %]">[% savedreport.id | html %]</label>
>                                                     </td>
>                                                     <td class="report_name">
>                                                         [% IF ( savedreport.report_name ) %]
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 24959: 101495 | 101538 | 101540 | 101767