Bugzilla – Attachment 101582 Details for
Bug 24829
ClaimReturnedWarningThreshold is always triggered if patron has one or more claims
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24829: ClaimReturnedWarningThreshold is always triggered if patron has one or more claims
Bug-24829-ClaimReturnedWarningThreshold-is-always-.patch (text/plain), 1.87 KB, created by
PTFS Europe Sandboxes
on 2020-03-24 13:53:26 UTC
(
hide
)
Description:
Bug 24829: ClaimReturnedWarningThreshold is always triggered if patron has one or more claims
Filename:
MIME Type:
Creator:
PTFS Europe Sandboxes
Created:
2020-03-24 13:53:26 UTC
Size:
1.87 KB
patch
obsolete
>From 4b60cdc8c110721f0268fc85008b3c00d0cf8fa7 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Mon, 9 Mar 2020 09:33:54 -0400 >Subject: [PATCH] Bug 24829: ClaimReturnedWarningThreshold is always triggered > if patron has one or more claims > >ClaimReturnedWarningThreshold is supposed to display a warning if a patron has more than the number of claims specified in the system preference. Currently the warning is displayed for any number of claims over zero. > >Test Plan: >1) Make 3 return claims for a patron >2) Set ClaimReturnedWarningThreshold to 4 >3) Note the claims warning displays for the patron on circulation.pl >4) Apply this patch >5) Reload circulation.pl, the warning should go away >6) Set ClaimReturnedWarningThreshold to 2 >7) Reload the page, the warning should reappear > >Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >index 167a20355b..9087ccb03d 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >@@ -752,7 +752,7 @@ > > [% SET ClaimReturnedWarningThreshold = Koha.Preference('ClaimReturnedWarningThreshold') %] > [% SET return_claims = patron.return_claims %] >- [% IF return_claims.count %] >+ [% IF return_claims.count > ClaimReturnedWarningThreshold %] > <li><span class="circ-hlt return-claims">Return claims: Patron has [% return_claims.count | html %] RETURN CLAIMS.</span> > [% END %] > >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24829
:
100375
|
101582
|
101779