Attachment 101587 Details for Bug 24745 – Bug 24745: (follow-up) Correct return statement in news plugin

[patch] Bug 24745: (follow-up) Correct return statement in news plugin

Bug-24745-follow-up-Correct-return-statement-in-ne.patch (text/plain), 1.04 KB, created by Marcel de Rooy on 2020-03-24 14:06:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2020-03-24 14:06:28 UTC

Size: 1.04 KB

patch

obsolete

>From 94877beed064c0ed94d5902d0256ab62da927c3d Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Tue, 24 Mar 2020 12:42:11 +0000
>Subject: [PATCH] Bug 24745: (follow-up) Correct return statement in news
> plugin
>Content-Type: text/plain; charset=utf-8
>
>Subroutine should "return;" instead of "return 0;"
>We also prevent ProhibitExplicitReturnUndef by not returning "undef"
>explicitly.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Commit message edited.
>---
> Koha/Template/Plugin/KohaNews.pm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/Koha/Template/Plugin/KohaNews.pm b/Koha/Template/Plugin/KohaNews.pm
>index 713d07301a..efd08dd52f 100644
>--- a/Koha/Template/Plugin/KohaNews.pm
>+++ b/Koha/Template/Plugin/KohaNews.pm
>@@ -52,7 +52,7 @@ sub get {
>             blocktitle => $blocktitle
>         };
>     } else {
>-        return 0;
>+        return;
>     }
> }
> 
>@@ -79,4 +79,4 @@ the following TT code: [% KohaNews.get() %]
> 
> Owen Leonard <oleonard@myacpl.org>
> 
>-=cut
>\ No newline at end of file
>+=cut
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 24745: 99708 | 100151 | 100152 | 101558 | 101586 | 101587