Attachment 101622 Details for Bug 22844 – Bug 22844: (QA follow-up) Build items.json for UniqueItemFields

[patch] Bug 22844: (QA follow-up) Build items.json for UniqueItemFields

Bug-22844-QA-follow-up-Build-itemsjson-for-UniqueI.patch (text/plain), 4.44 KB, created by Jonathan Druart on 2020-03-24 16:09:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2020-03-24 16:09:09 UTC

Size: 4.44 KB

patch

obsolete

>From df24574c903bf6bdfb3e2dd8455f874f8ef4f6c3 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Fri, 10 May 2019 08:49:26 +0000
>Subject: [PATCH] Bug 22844: (QA follow-up) Build items.json for
> UniqueItemFields
>
>Adding items.json, built from latest kohastructure.sql.
>Control UniqueItemFields with this source file.
>And add StatisticsFields.
>
>Test plan:
>Go to Preferences, play with UniqueItemFields.
>Adjust StatisticsFields and look at patron record, statistics tab.
>
>Moved-from: Bug 22867
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>
>Signed-off-by: David Nind <david@davidnind.com>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> .../admin/preferences/acquisitions.pref       |  3 +-
> .../en/modules/admin/preferences/items.json   | 47 +++++++++++++++++++
> .../en/modules/admin/preferences/patrons.pref |  5 +-
> 3 files changed, 52 insertions(+), 3 deletions(-)
> create mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/items.json
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref
>index c6d8d8d55c..9d9fe823a2 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref
>@@ -11,7 +11,8 @@ Acquisitions:
>         -
>             - "The following <a href='http://schema.koha-community.org/__VERSION__/tables/items.html' target='blank'>database columns</a> should be unique in an item:"
>             - pref: UniqueItemFields
>-            - (separate columns with |)
>+              type: modalselect
>+              source: items
>         -
>             - When closing or reopening a basket,
>             - pref: BasketConfirmations
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/items.json b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/items.json
>new file mode 100644
>index 0000000000..af89c0fafe
>--- /dev/null
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/items.json
>@@ -0,0 +1,47 @@
>+{
>+    "itemnumber": "itemnumber",
>+    "biblionumber": "biblionumber",
>+    "biblioitemnumber": "biblioitemnumber",
>+    "barcode": "barcode",
>+    "dateaccessioned": "dateaccessioned",
>+    "booksellerid": "booksellerid",
>+    "homebranch": "homebranch",
>+    "price": "price",
>+    "replacementprice": "replacementprice",
>+    "replacementpricedate": "replacementpricedate",
>+    "datelastborrowed": "datelastborrowed",
>+    "datelastseen": "datelastseen",
>+    "stack": "stack",
>+    "notforloan": "notforloan",
>+    "damaged": "damaged",
>+    "damaged_on": "damaged_on",
>+    "itemlost": "itemlost",
>+    "itemlost_on": "itemlost_on",
>+    "withdrawn": "withdrawn",
>+    "withdrawn_on": "withdrawn_on",
>+    "itemcallnumber": "itemcallnumber",
>+    "coded_location_qualifier": "coded_location_qualifier",
>+    "issues": "issues",
>+    "renewals": "renewals",
>+    "reserves": "reserves",
>+    "restricted": "restricted",
>+    "itemnotes": "itemnotes",
>+    "itemnotes_nonpublic": "itemnotes_nonpublic",
>+    "holdingbranch": "holdingbranch",
>+    "paidfor": "paidfor",
>+    "timestamp": "timestamp",
>+    "location": "location",
>+    "permanent_location": "permanent_location",
>+    "onloan": "onloan",
>+    "cn_source": "cn_source",
>+    "cn_sort": "cn_sort",
>+    "ccode": "ccode",
>+    "materials": "materials",
>+    "uri": "uri",
>+    "itype": "itype",
>+    "more_subfields_xml": "more_subfields_xml",
>+    "enumchron": "enumchron",
>+    "copynumber": "copynumber",
>+    "stocknumber": "stocknumber",
>+    "new_status": "new_status"
>+}
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref
>index ec6b9b5feb..c32d84cf98 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref
>@@ -190,8 +190,9 @@ Patrons:
>      -
>          - "Show the following fields from the items database table as columns on the statistics tab on the patron record: "
>          - pref: StatisticsFields
>-           class: multi
>-         - "(separate fields with |, without trailing |). Default if empty: location|itype|ccode"
>+           type: modalselect
>+           source: items
>+         - "If empty, defaults to: location|itype|ccode"
>      -
>          - pref: EnableBorrowerFiles
>            choices:
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 22844: 89322 | 89323 | 89389 | 89403 | 89530 | 89531 | 89749 | 89903 | 89904 | 89905 | 90407 | 96007 | 98145 | 98146 | 98147 | 98148 | 98149 | 98150 | 98151 | 98297 | 98298 | 100440 | 100441 | 100442 | 100443 | 100444 | 100445 | 100446 | 100447 | 101198 | 101199 | 101200 | 101201 | 101202 | 101203 | 101204 | 101205 | 101302 | 101480 | 101481 | 101482 | 101483 | 101484 | 101485 | 101486 | 101487 | 101488 | 101617 | 101618 | 101619 | 101620 | 101621 | 101622 | 101623 | 101624 | 103842 | 103843 | 103844 | 103845 | 103846 | 103847 | 103848 | 103849 | 103850 | 103904 | 103960 | 103961 | 103962 | 103963 | 103964 | 103965 | 103966 | 103967 | 103968 | 103969 | 106545 | 106546 | 106547 | 106548 | 106549 | 106550 | 106551 | 106552 | 106553 | 106554 | 107126