Attachment 10164 Details for Bug 4118 – Bugfix 4118 - Add Collection Code to Statistics Table - Updated C4 Modules to add Collection Codes to stats table

[patch] Bugfix 4118 - Add Collection Code to Statistics Table - Updated C4 Modules to add Collection Codes to stats table

Bugfix-4118---Add-Collection-Code-to-Statistics-Ta.patch (text/plain), 3.08 KB, created by Kyle M Hall on 2012-06-11 09:36:02 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall

Created: 2012-06-11 09:36:02 UTC

Size: 3.08 KB

patch

obsolete

>From cd298eb4fa28cef6ed04e7ad641d6ea13d31ee81 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle.m.hall@gmail.com>
>Date: Fri, 5 Feb 2010 16:04:53 +0000
>Subject: [PATCH] Bugfix 4118 - Add Collection Code to Statistics Table - Updated C4 Modules to add Collection Codes to stats table
>
>---
> C4/Circulation.pm |    8 ++++----
> C4/Stats.pm       |    8 ++++----
> 2 files changed, 8 insertions(+), 8 deletions(-)
>
>diff --git a/C4/Circulation.pm b/C4/Circulation.pm
>index 9b523e3..2abb593 100644
>--- a/C4/Circulation.pm
>+++ b/C4/Circulation.pm
>@@ -714,7 +714,7 @@ sub CanBookBeIssued {
>     #
>     if ( $borrower->{'category_type'} eq 'X' && (  $item->{barcode}  )) { 
>     	# stats only borrower -- add entry to statistics table, and return issuingimpossible{STATS} = 1  .
>-        &UpdateStats(C4::Context->userenv->{'branch'},'localuse','','',$item->{'itemnumber'},$item->{'itemtype'},$borrower->{'borrowernumber'});
>+        &UpdateStats(C4::Context->userenv->{'branch'},'localuse','','',$item->{'itemnumber'},$item->{'itemtype'},$borrower->{'borrowernumber'}, undef, $item->{'ccode'});
>         ModDateLastSeen( $item->{'itemnumber'} );
>         return( { STATS => 1 }, {});
>     }
>@@ -1095,7 +1095,7 @@ sub AddIssue {
>             C4::Context->userenv->{'branch'},
>             'issue', $charge,
>             ($sipmode ? "SIP-$sipmode" : ''), $item->{'itemnumber'},
>-            $item->{'itype'}, $borrower->{'borrowernumber'}
>+            $item->{'itype'}, $borrower->{'borrowernumber'}, undef, $item->{'ccode'}
>         );
> 
>         # Send a checkout slip.
>@@ -1694,7 +1694,7 @@ sub AddReturn {
>         $branch, $stat_type, '0', '',
>         $item->{'itemnumber'},
>         $biblio->{'itemtype'},
>-        $borrowernumber
>+        $borrowernumber, undef, $item->{'ccode'}
>     );
> 
>     # Send a check-in slip. # NOTE: borrower may be undef.  probably shouldn't try to send messages then.
>@@ -2419,7 +2419,7 @@ sub AddRenewal {
>             'Rent', $charge, $itemnumber );
>     }
>     # Log the renewal
>-    UpdateStats( $branch, 'renew', $charge, '', $itemnumber, $item->{itype}, $borrowernumber);
>+    UpdateStats( $branch, 'renew', $charge, '', $itemnumber, $item->{itype}, $borrowernumber, undef, $item->{'ccode'});
> 	return $datedue;
> }
> 
>diff --git a/C4/Stats.pm b/C4/Stats.pm
>index 11710f8..a6ad2ca 100644
>--- a/C4/Stats.pm
>+++ b/C4/Stats.pm
>@@ -76,20 +76,20 @@ sub UpdateStats {
>     my (
>         $branch,         $type,
>         $amount,   $other,          $itemnum,
>-        $itemtype, $borrowernumber, $accountno
>+        $itemtype, $borrowernumber, $accountno, $ccode
>       )
>       = @_;
>     my $dbh = C4::Context->dbh;
>     my $sth = $dbh->prepare(
>         "INSERT INTO statistics
>         (datetime, branch, type, value,
>-         other, itemnumber, itemtype, borrowernumber, proccode)
>-         VALUES (now(),?,?,?,?,?,?,?,?)"
>+         other, itemnumber, itemtype, borrowernumber, proccode, ccode)
>+         VALUES (now(),?,?,?,?,?,?,?,?,?)"
>     );
>     $sth->execute(
>         $branch,    $type,    $amount,
>         $other,     $itemnum, $itemtype, $borrowernumber,
>-		$accountno
>+		$accountno, $ccode
>     );
> }
> 
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 4118: 1848 | 1849 | 10164 | 10165 | 10213 | 10214 | 10602 | 10603 | 10604 | 10605 | 10887 | 11322 | 12172 | 12173 | 12792 | 12793 | 12795