Attachment 10167 Details for Bug 8089 – Bug 8089: Cache sysprefs using Koha::Cache

[patch] Bug 8089: Cache sysprefs using Koha::Cache

Bug-8089-Cache-sysprefs-using-KohaCache.patch (text/plain), 2.20 KB, created by Kyle M Hall on 2012-06-11 10:08:46 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall

Created: 2012-06-11 10:08:46 UTC

Size: 2.20 KB

patch

obsolete

>From 4be1862c51fb453c76f6d0fb952e5f1222084f44 Mon Sep 17 00:00:00 2001
>From: Jared Camins-Esakov <jcamins@cpbibliography.com>
>Date: Tue, 15 May 2012 07:14:01 -0400
>Subject: [PATCH] Bug 8089: Cache sysprefs using Koha::Cache
>
>Cache sysprefs using Koha::Cache in a way that is safe even for
>caching-related sysprefs. This lays the groundwork for removing
>caching configuration from the httpd.conf and configuring it
>using sysprefs.
>
>Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
>---
> C4/Context.pm |   20 ++++++++++++++++++++
> 1 files changed, 20 insertions(+), 0 deletions(-)
>
>diff --git a/C4/Context.pm b/C4/Context.pm
>index a451aa4..865c2a0 100644
>--- a/C4/Context.pm
>+++ b/C4/Context.pm
>@@ -487,11 +487,20 @@ my %sysprefs;
> sub preference {
>     my $self = shift;
>     my $var  = lc(shift);                          # The system preference to return
>+    my $cache;
> 
>     if (exists $sysprefs{$var}) {
>         return $sysprefs{$var};
>     }
> 
>+    if (Koha::Cache->is_cache_active()) {
>+        $cache = Koha::Cache->new();
>+        if (defined $cache) {
>+            $sysprefs{$var} = $cache->get_from_cache("syspref:$var");
>+            return $sysprefs{$var} if (defined $sysprefs{$var});
>+        }
>+    }
>+
>     my $dbh  = C4::Context->dbh or return 0;
> 
>     # Look up systempreferences.variable==$var
>@@ -502,6 +511,9 @@ sub preference {
>         LIMIT    1
> END_SQL
>     $sysprefs{$var} = $dbh->selectrow_array( $sql, {}, $var );
>+    if (Koha::Cache->is_cache_active() && defined $cache) {
>+        $cache->set_in_cache("syspref:$var");
>+    }
>     return $sysprefs{$var};
> }
> 
>@@ -524,6 +536,10 @@ will not be seen by this process.
> 
> sub clear_syspref_cache {
>     %sysprefs = ();
>+    if (Koha::Cache->is_cache_active()) {
>+        my $cache = Koha::Cache->new();
>+        $cache->flush_all() if defined $cache; # Sorry, this is unpleasant
>+    }
> }
> 
> =head2 set_preference
>@@ -554,6 +570,10 @@ sub set_preference {
>     " );
> 
>     if($sth->execute( $var, $value )) {
>+        if (Koha::Cache->is_cache_active()) {
>+            my $cache = Koha::Cache->new();
>+            $cache->set_in_cache("syspref:$var", $value) if defined $cache;
>+        }
>         $sysprefs{$var} = $value;
>     }
>     $sth->finish;
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 8089: 9577 | 9580 | 9581 | 9665 | 9666 | 9673 | 10166 | 10167 | 10168 | 11400 | 11401 | 11402 | 12077 | 12078 | 14765 | 14891 | 14893 | 16551