Attachment 101685 Details for Bug 23355 – Bug 23355: (RM follow-up) Make DB update idempotent

[patch] Bug 23355: (RM follow-up) Make DB update idempotent

Bug-23355-RM-follow-up-Make-DB-update-idempotent.patch (text/plain), 2.10 KB, created by Martin Renvoize (ashimema) on 2020-03-25 11:32:29 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2020-03-25 11:32:29 UTC

Size: 2.10 KB

patch

obsolete

>From be3c868169b049a33e477bf31fa63e8c3a431899 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Wed, 25 Mar 2020 11:19:17 +0000
>Subject: [PATCH] Bug 23355: (RM follow-up) Make DB update idempotent
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> installer/data/mysql/updatedatabase.pl | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
>diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl
>index 8a7c08b70e..65ecbb7169 100755
>--- a/installer/data/mysql/updatedatabase.pl
>+++ b/installer/data/mysql/updatedatabase.pl
>@@ -21274,14 +21274,14 @@ if( CheckVersion( $DBversion ) ) {
> $DBversion = '19.12.00.054';
> if( CheckVersion( $DBversion ) ) {
>     $dbh->do(qq{
>-             CREATE TABLE desks ( -- desks available in a library
>-             desk_id int(11) NOT NULL auto_increment, -- unique identifier added by Koha
>-             desk_name varchar(100) NOT NULL default '', -- name of the desk
>-             branchcode varchar(10) NOT NULL,       -- library the desk is located at
>-             PRIMARY KEY  (desk_id),
>-             KEY `fk_desks_branchcode` (branchcode),
>-             CONSTRAINT `fk_desks_branchcode` FOREIGN KEY (branchcode) REFERENCES branches (branchcode) ON DELETE CASCADE ON UPDATE CASCADE
>-             ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci;
>+         CREATE TABLE IF NOT EXISTS `desks` ( -- desks available in a library
>+           `desk_id` int(11) NOT NULL auto_increment, -- unique identifier added by Koha
>+           `desk_name` varchar(100) NOT NULL default '', -- name of the desk
>+           `branchcode` varchar(10) NOT NULL,       -- library the desk is located at
>+           PRIMARY KEY (`desk_id`),
>+           KEY `fk_desks_branchcode` (`branchcode`),
>+           CONSTRAINT `fk_desks_branchcode` FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`) ON DELETE CASCADE ON UPDATE CASCADE
>+         ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci;
>     });
> 
>     NewVersion( $DBversion, 13881, "Add desk management");
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 23355: 92941 | 92942 | 92943 | 92944 | 92945 | 92946 | 92947 | 92948 | 92949 | 92950 | 92951 | 92952 | 92953 | 97031 | 97032 | 97033 | 97034 | 97035 | 97036 | 97037 | 97038 | 97039 | 97040 | 97041 | 97043 | 97044 | 97045 | 97046 | 97047 | 97048 | 97049 | 97050 | 97051 | 97052 | 97053 | 97054 | 97077 | 97078 | 97079 | 97080 | 97081 | 97082 | 97083 | 97084 | 97085 | 97086 | 97087 | 97088 | 97089 | 97706 | 97707 | 97708 | 97709 | 97710 | 97711 | 97712 | 97713 | 97714 | 97715 | 97716 | 97784 | 97785 | 97786 | 97787 | 97788 | 97789 | 97790 | 97791 | 97792 | 97793 | 97794 | 97816 | 97817 | 97818 | 97819 | 97820 | 97821 | 97822 | 97823 | 98026 | 98027 | 98028 | 98835 | 98836 | 98837 | 98838 | 98839 | 98840 | 98841 | 98842 | 100009 | 100010 | 100011 | 100012 | 100013 | 100014 | 100015 | 100016 | 100017 | 100018 | 100019 | 100020 | 100021 | 100030 | 100090 | 101685