Attachment 101687 Details for Bug 18177 – Bug 18177: remove aqbooksellers.othersupplier

[patch] Bug 18177: remove aqbooksellers.othersupplier

Bug-18177-remove-aqbooksellersothersupplier.patch (text/plain), 1.67 KB, created by Martin Renvoize (ashimema) on 2020-03-25 11:40:38 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2020-03-25 11:40:38 UTC

Size: 1.67 KB

patch

obsolete

>From b9439edd7dffe7ed30ec914baad5a995d2aa7365 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 17 Mar 2020 09:40:04 +0100
>Subject: [PATCH] Bug 18177: remove aqbooksellers.othersupplier
>
>This patchset removes some columns from the aqbooksellers table that are
>not used:
> * booksellerfax
> * booksellerurl
> * bookselleremail
> * othersupplier
> * currency
>
>The first 3 ones are certainly leftover from bug 10402.
>
>Test plan:
>For each for these fields you will make sure that they cannot be edited
>from the interface.
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> Koha/Acquisition/Bookseller.pm | 1 -
> t/db_dependent/Bookseller.t    | 2 +-
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/Koha/Acquisition/Bookseller.pm b/Koha/Acquisition/Bookseller.pm
>index 6694f43288..1677aab372 100644
>--- a/Koha/Acquisition/Bookseller.pm
>+++ b/Koha/Acquisition/Bookseller.pm
>@@ -86,7 +86,6 @@ sub to_api_mapping {
>         bookselleremail => undef,
>         booksellerurl   => undef,
>         currency        => undef,
>-        othersupplier   => undef,
>         listprice       => 'list_currency',
>         invoiceprice    => 'invoice_currency',
>         gstreg          => 'gst',
>diff --git a/t/db_dependent/Bookseller.t b/t/db_dependent/Bookseller.t
>index ace46b86ed..e4d24a36d4 100644
>--- a/t/db_dependent/Bookseller.t
>+++ b/t/db_dependent/Bookseller.t
>@@ -767,7 +767,7 @@ sub field_filter {
> 
>     for my $field (
>         'bookselleremail', 'booksellerfax',
>-        'booksellerurl',   'othersupplier',
>+        'booksellerurl',
>         'currency',        'invoiceprice',
>         'listprice',       'contacts'
>       )
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 18177: 100861 | 100862 | 100863 | 100864 | 100865 | 100866 | 100867 | 100868 | 100869 | 100870 | 100871 | 100872 | 100873 | 100874 | 101612 | 101687 | 101688 | 101689 | 101690 | 101691 | 101692 | 101693 | 101694 | 101958 | 101959 | 101960 | 101961 | 101962 | 101963 | 101964 | 101965 | 102011