Attachment 101690 Details for Bug 18177 – Bug 18177: remove aqbooksellers.bookselleremail

[patch] Bug 18177: remove aqbooksellers.bookselleremail

Bug-18177-remove-aqbooksellersbookselleremail.patch (text/plain), 1.72 KB, created by Martin Renvoize (ashimema) on 2020-03-25 11:40:48 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2020-03-25 11:40:48 UTC

Size: 1.72 KB

patch

obsolete

>From f8b3c21fb4fe9e703bb41e47a2bdbd3a22e3581f Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 17 Mar 2020 09:47:46 +0100
>Subject: [PATCH] Bug 18177: remove aqbooksellers.bookselleremail
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> C4/Letters.pm                  | 1 -
> Koha/Acquisition/Bookseller.pm | 1 -
> t/db_dependent/Bookseller.t    | 1 -
> 3 files changed, 3 deletions(-)
>
>diff --git a/C4/Letters.pm b/C4/Letters.pm
>index 9e583cd5ae..c75767e26c 100644
>--- a/C4/Letters.pm
>+++ b/C4/Letters.pm
>@@ -449,7 +449,6 @@ sub SendAlerts {
> 
>         my @email;
>         my @cc;
>-        push @email, $databookseller->{bookselleremail} if $databookseller->{bookselleremail};
>         push @email, $datacontact->{email}           if ( $datacontact && $datacontact->{email} );
>         unless (@email) {
>             warn "Bookseller $dataorders->[0]->{booksellerid} without emails";
>diff --git a/Koha/Acquisition/Bookseller.pm b/Koha/Acquisition/Bookseller.pm
>index 9fe5caccf9..a96806bb50 100644
>--- a/Koha/Acquisition/Bookseller.pm
>+++ b/Koha/Acquisition/Bookseller.pm
>@@ -82,7 +82,6 @@ on the API.
> 
> sub to_api_mapping {
>     return {
>-        bookselleremail => undef,
>         currency        => undef,
>         listprice       => 'list_currency',
>         invoiceprice    => 'invoice_currency',
>diff --git a/t/db_dependent/Bookseller.t b/t/db_dependent/Bookseller.t
>index 33324dd3bd..3bb98bdd6f 100644
>--- a/t/db_dependent/Bookseller.t
>+++ b/t/db_dependent/Bookseller.t
>@@ -766,7 +766,6 @@ sub field_filter {
>     my ($struct) = @_;
> 
>     for my $field (
>-        'bookselleremail',
>         'currency',        'invoiceprice',
>         'listprice',       'contacts'
>       )
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 18177: 100861 | 100862 | 100863 | 100864 | 100865 | 100866 | 100867 | 100868 | 100869 | 100870 | 100871 | 100872 | 100873 | 100874 | 101612 | 101687 | 101688 | 101689 | 101690 | 101691 | 101692 | 101693 | 101694 | 101958 | 101959 | 101960 | 101961 | 101962 | 101963 | 101964 | 101965 | 102011