Bugzilla – Attachment 10174 Details for
Bug 8227
Remove compile time warning from C4::Serials
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Proposed Patch
0001-Bug-8227-Fix-deprecated-construct-compile-time-warni.patch (text/plain), 1.05 KB, created by
Colin Campbell
on 2012-06-11 10:45:05 UTC
(
hide
)
Description:
Proposed Patch
Filename:
MIME Type:
Creator:
Colin Campbell
Created:
2012-06-11 10:45:05 UTC
Size:
1.05 KB
patch
obsolete
>From 243cb9c58f19600b07748bd28d8a383ef7824c9d Mon Sep 17 00:00:00 2001 >From: Colin Campbell <colin.campbell@ptfs-europe.com> >Date: Mon, 11 Jun 2012 11:32:58 +0100 >Subject: [PATCH] Bug 8227 Fix deprecated construct compile time warning in > Serials > >The perl parser no longer fools itself into sometimes thinking >qw( ... ) is a ( qw( ... )) this adds the required parentheses >for the foreach expression silencing the compile time warning >--- > C4/Serials.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Serials.pm b/C4/Serials.pm >index 07f0948..acd48b1 100644 >--- a/C4/Serials.pm >+++ b/C4/Serials.pm >@@ -601,7 +601,7 @@ sub GetSubscriptions { > my @sqlstrings; > my @strings_to_search; > @strings_to_search = map { "$_" } split( / /, $ean ); >- foreach my $index qw(biblioitems.ean) { >+ foreach my $index ( qw(biblioitems.ean) ) { > push @bind_params, @strings_to_search; > my $tmpstring = "OR $index = ? " x scalar(@strings_to_search); > $debug && warn "$tmpstring"; >-- >1.7.11.rc0 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8227
:
10174
|
10246