Attachment 101811 Details for Bug 24475 – Bug 24475: Reword FinesMode system preference

[patch] Bug 24475: Reword FinesMode system preference

Bug-24475-Reword-FinesMode-system-preference.patch (text/plain), 2.94 KB, created by Kyle M Hall (khall) on 2020-03-26 11:42:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2020-03-26 11:42:51 UTC

Size: 2.94 KB

patch

obsolete

>From 8651d113f7fc7d8d3aeb31fde158673a10bfb4ec Mon Sep 17 00:00:00 2001
>From: David Roberts <david@koha-ptfs.co.uk>
>Date: Wed, 25 Mar 2020 21:59:22 +0000
>Subject: [PATCH] Bug 24475: Reword FinesMode system preference
>
>This patch changes the wording of the FinesMode and
>CalculateFinesOnReturn system preferences explanations
>
>1) Install Patch
>2) Check that the wording of the FinesMode system preference has changed
>to "NOTE: If the misc/cronjobs/fines.pl cronjob is being run, accruing
>and final fines will be calculated when the cron runs and accruing fines
>will be finalized when an item is returned. If CalculateFinesOnReturn is
>enabled, final fines will be calculated when an item is returned."
>3) Check that the wording of the CalculateFinesOnReturn system
>preference has changed to add "NOTE: This system preference requires
>FinesMode to be set to 'Calculate and charge.'" to the existing note.
>
>Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> .../prog/en/modules/admin/preferences/circulation.pref | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
>index fefa8e79bb..4f3d97716d 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
>@@ -544,6 +544,7 @@ Circulation:
> no: "Don't"
> - calculate and update overdue charges when an item is returned.
> - " NOTE: If you are doing hourly loans then you should have this on."
>+ - " NOTE: This system preference requires FinesMode to be set to 'Calculate and charge.'"
> -
> - pref: UpdateItemLocationOnCheckin
> type: textarea
>@@ -883,8 +884,7 @@ Circulation:
> off: "Don't calculate"
> production: Calculate and charge
> - fines (when <code>misc/cronjobs/fines.pl</code> is being run).
>- - " NOTE: Fines can also be charged by the CalculateFinesOnReturn system preference."
>- - " NOTE: This system preference requires the <code>misc/cronjobs/fines.pl</code> cronjob. Ask your system administrator to schedule it."
>+ - " NOTE: If the misc/cronjobs/fines.pl cronjob is being run, accruing and final fines will be calculated when the cron runs and accruing fines will be finalized when an item is returned. If CalculateFinesOnReturn is enabled, final fines will be calculated when an item is returned."
> -
> - If a lost item is returned, apply the refunding rules defined in the
> - pref: RefundLostOnReturnControl
>-- 
>2.21.1 (Apple Git-122.3)

Actions: View | Diff | Splinter Review

Attachments on bug 24475: 97954 | 97984 | 99003 | 101780 | 101800 | 101811 | 101812