Attachment 101822 Details for Bug 24964 – Bug 24964: Prevent random failures sorting by borrowernumber

[patch] Bug 24964: Prevent random failures sorting by borrowernumber

Bug-24964-Prevent-random-failures-sorting-by-borro.patch (text/plain), 1.18 KB, created by Kyle M Hall (khall) on 2020-03-26 12:54:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2020-03-26 12:54:36 UTC

Size: 1.18 KB

patch

obsolete

>From 97920170708330d83fd8675e07fe58b2720235bc Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 25 Mar 2020 13:50:45 +0100
>Subject: [PATCH] Bug 24964: Prevent random failures sorting by borrowernumber
>
>Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> t/db_dependent/Utils/Datatables_Members.t | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/Utils/Datatables_Members.t b/t/db_dependent/Utils/Datatables_Members.t
>index 85bebcd0fc..c91c69aaa0 100644
>--- a/t/db_dependent/Utils/Datatables_Members.t
>+++ b/t/db_dependent/Utils/Datatables_Members.t
>@@ -541,7 +541,7 @@ subtest 'Search with permissions' => sub {
>     is( $search_results->{iTotalDisplayRecords},
>         3, "We find 3 patrons with suggestions_manage permission" );
>     is_deeply(
>-        [ map { $_->{borrowernumber} } @{ $search_results->{patrons} } ],
>+        [ sort map { $_->{borrowernumber} } @{ $search_results->{patrons} } ],
>         [
>             $superlibrarian->borrowernumber,
>             $librarian_with_full_permission->borrowernumber,
>-- 
>2.21.1 (Apple Git-122.3)

Actions: View | Diff | Splinter Review

Attachments on bug 24964: 101668 | 101669 | 101686 | 101702 | 101813 | 101814 | 101815 | 101820 | 101821 | 101822 | 101823 | 102434 | 102435 | 102457 | 102458 | 102459 | 102460 | 102461