Bugzilla – Attachment 101823 Details for
Bug 24964
Do not filter patrons AFTER they have been fetched from the DB (when searching with permissions)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24964: Fix perl critic warning
Bug-24964-Fix-perl-critic-warning.patch (text/plain), 929 bytes, created by
Kyle M Hall (khall)
on 2020-03-26 12:54:39 UTC
(
hide
)
Description:
Bug 24964: Fix perl critic warning
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2020-03-26 12:54:39 UTC
Size:
929 bytes
patch
obsolete
>From 979c2346bb81a291700c5989725e36d7cd5272ab Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Thu, 26 Mar 2020 08:53:59 -0400 >Subject: [PATCH] Bug 24964: Fix perl critic warning > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > C4/Utils/DataTables/Members.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Utils/DataTables/Members.pm b/C4/Utils/DataTables/Members.pm >index d2b4089dc4..b0d1d0b1d7 100644 >--- a/C4/Utils/DataTables/Members.pm >+++ b/C4/Utils/DataTables/Members.pm >@@ -172,7 +172,7 @@ sub search { > push @where_args, ($has_permission->{module_bit}) x 2, $has_permission->{subpermission}; > } > >- my $where = " WHERE " . join (" AND ", @where_strs) if @where_strs; >+ my $where = @where_strs ? " WHERE " . join (" AND ", @where_strs) : undef; > my $orderby = dt_build_orderby($dt_params); > > my $limit; >-- >2.21.1 (Apple Git-122.3)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24964
:
101668
|
101669
|
101686
|
101702
|
101813
|
101814
|
101815
|
101820
|
101821
|
101822
| 101823 |
102434
|
102435
|
102457
|
102458
|
102459
|
102460
|
102461