Attachment 101829 Details for Bug 24860 – Bug 24860: Implement reserves.volume_id

[patch] Bug 24860: Implement reserves.volume_id

Bug-24860-Implement-reservesvolumeid.patch (text/plain), 3.64 KB, created by Kyle M Hall (khall) on 2020-03-26 13:27:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2020-03-26 13:27:49 UTC

Size: 3.64 KB

patch

obsolete

>From 44d3624878a5f7d5295733e5ab78b4a243b3cc63 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Fri, 28 Feb 2020 14:45:44 -0500
>Subject: [PATCH] Bug 24860: Implement reserves.volume_id
>
>---
> C4/Reserves.pm                       |  2 ++
> Koha/REST/V1/Holds.pm                |  2 ++
> api/v1/swagger/definitions/hold.json |  4 ++++
> api/v1/swagger/paths/holds.json      | 10 ++++++++++
> 4 files changed, 18 insertions(+)
>
>diff --git a/C4/Reserves.pm b/C4/Reserves.pm
>index 08b16893da..8a9659ef11 100644
>--- a/C4/Reserves.pm
>+++ b/C4/Reserves.pm
>@@ -184,6 +184,7 @@ sub AddReserve {
>     my $checkitem      = $params->{itemnumber};
>     my $found          = $params->{found};
>     my $itemtype       = $params->{itemtype};
>+    my $volume_id      = $params->{volume_id};
> 
>     $resdate = output_pref( { str => dt_from_string( $resdate ), dateonly => 1, dateformat => 'iso' })
>         or output_pref({ dt => dt_from_string, dateonly => 1, dateformat => 'iso' });
>@@ -237,6 +238,7 @@ sub AddReserve {
>         {
>             borrowernumber => $borrowernumber,
>             biblionumber   => $biblionumber,
>+            volume_id      => $volume_id,
>             reservedate    => $resdate,
>             branchcode     => $branch,
>             priority       => $priority,
>diff --git a/Koha/REST/V1/Holds.pm b/Koha/REST/V1/Holds.pm
>index a806d6757a..ffb4599864 100644
>--- a/Koha/REST/V1/Holds.pm
>+++ b/Koha/REST/V1/Holds.pm
>@@ -78,6 +78,7 @@ sub add {
>         my $biblio;
> 
>         my $biblio_id         = $body->{biblio_id};
>+        my $volume_id         = $body->{volume_id};
>         my $pickup_library_id = $body->{pickup_library_id};
>         my $item_id           = $body->{item_id};
>         my $patron_id         = $body->{patron_id};
>@@ -173,6 +174,7 @@ sub add {
>                 itemnumber       => $item_id,
>                 found            => undef,                # TODO: Why not?
>                 itemtype         => $item_type,
>+                volume_id        => $volume_id,
>             }
>         );
> 
>diff --git a/api/v1/swagger/definitions/hold.json b/api/v1/swagger/definitions/hold.json
>index dda32600b3..bf21951fe7 100644
>--- a/api/v1/swagger/definitions/hold.json
>+++ b/api/v1/swagger/definitions/hold.json
>@@ -18,6 +18,10 @@
>       "type": "integer",
>       "description": "Internal biblio identifier"
>     },
>+    "volume_id": {
>+      "type": ["integer", "null"],
>+      "description": "Internal volume identifier for the volume to place on hold"
>+    },
>     "pickup_library_id": {
>       "type": ["string", "null"],
>       "description": "Internal library identifier for the pickup library"
>diff --git a/api/v1/swagger/paths/holds.json b/api/v1/swagger/paths/holds.json
>index 2bb0ed0179..89e5d72c36 100644
>--- a/api/v1/swagger/paths/holds.json
>+++ b/api/v1/swagger/paths/holds.json
>@@ -30,6 +30,12 @@
>           "description": "Internal biblio identifier",
>           "type": "integer"
>         },
>+        {
>+          "name": "volume_id",
>+          "in": "query",
>+          "description": "Internal volume identifier for the volume to place on hold",
>+          "type": "integer"
>+        },
>         {
>           "name": "pickup_library_id",
>           "in": "query",
>@@ -181,6 +187,10 @@
>                 "description": "Internal biblio identifier",
>                 "type": [ "integer", "null" ]
>               },
>+              "volume_id": {
>+                "description": "Internal volume identifier for the volume to place on hold",
>+                "type": [ "integer", "null" ]
>+              },
>               "item_id": {
>                 "description": "Internal item identifier",
>                 "type": [ "integer", "null" ]
>-- 
>2.21.1 (Apple Git-122.3)

Actions: View | Diff | Splinter Review

Attachments on bug 24860: 100644 | 100645 | 100646 | 100647 | 100648 | 100649 | 100650 | 100651 | 101744 | 101745 | 101746 | 101747 | 101748 | 101749 | 101750 | 101751 | 101827 | 101828 | 101829 | 101830 | 101831 | 101832 | 101833 | 101834 | 101835 | 102230 | 102231 | 102232 | 102233 | 102234 | 102235 | 102236 | 102237 | 102238 | 102239 | 102240 | 102241 | 102242 | 102243 | 102244 | 102245 | 102246 | 102247 | 106589 | 106590 | 106591 | 106592 | 106593 | 106594 | 106595 | 106596 | 106597 | 106682 | 106683 | 106684 | 106685 | 106686 | 106687 | 106688 | 106689 | 106690 | 106742 | 106743 | 106744 | 106745 | 106746 | 106747 | 106748 | 106749 | 106750 | 108458 | 108459 | 108460 | 108461 | 108462 | 108463 | 108464 | 108465 | 108466 | 109097 | 109098 | 109099 | 109100 | 109101 | 109102 | 109103 | 109104 | 109105 | 109171 | 109172 | 109173 | 109174 | 109175 | 109176 | 109177 | 109178 | 109179 | 113616 | 113617 | 113618 | 113619 | 113620 | 113621 | 113622 | 113623 | 113624 | 135922 | 135923 | 135924 | 135925 | 135926 | 135927 | 135928 | 135929 | 135930 | 138221 | 138222 | 138224 | 138225 | 138226 | 138227 | 138228 | 138229 | 138230 | 141214 | 141215 | 141735 | 141736 | 141737 | 141738 | 141739 | 141740 | 141741 | 141742 | 141743 | 141744 | 141745 | 141746 | 141747 | 141748 | 141749 | 141750 | 142413 | 142414 | 142415 | 142416 | 142417 | 142418 | 142419 | 142420 | 142421 | 142422 | 142423 | 142424 | 142425 | 142426 | 142427 | 142428 | 142429 | 142430 | 142827 | 142955 | 142956 | 142957 | 142958 | 142959 | 142960 | 142961 | 142962 | 142963 | 142964 | 142965 | 142966 | 142967 | 142968 | 142969 | 142970 | 142971 | 142972 | 142973 | 142974 | 142975 | 142992 | 142993 | 142994 | 142995 | 142996 | 142997 | 142998 | 142999 | 143000 | 143001 | 143002 | 143003 | 143004 | 143005 | 143006 | 143007 | 143008 | 143009 | 143010 | 143011