Bugzilla – Attachment 101927 Details for
Bug 15522
New interface for revamped circulation rules
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15522: (follow-up) Handle deprecated rules
Bug-15522-follow-up-Handle-deprecated-rules.patch (text/plain), 1.49 KB, created by
Lari Taskula
on 2020-03-26 23:31:27 UTC
(
hide
)
Description:
Bug 15522: (follow-up) Handle deprecated rules
Filename:
MIME Type:
Creator:
Lari Taskula
Created:
2020-03-26 23:31:27 UTC
Size:
1.49 KB
patch
obsolete
>From 54b803d69282b09e6228de53c5e493fbda78ad24 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 21 Jan 2020 18:47:48 +0100 >Subject: [PATCH] Bug 15522: (follow-up) Handle deprecated rules > >Previous use of inArray was wrong. > >Signed-off-by: Lisette Scheer <lisettes@latahlibrary.org> >--- > koha-tmpl/intranet-tmpl/prog/js/src/admin/policy/rules.js | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/src/admin/policy/rules.js b/koha-tmpl/intranet-tmpl/prog/js/src/admin/policy/rules.js >index a46160eb9f..7616df6bbe 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/src/admin/policy/rules.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/src/admin/policy/rules.js >@@ -53,7 +53,11 @@ export default ( window.rules = new class { > > for ( let [ rule_name, rule_value ] of Object.entries( this.rules[ruleBranchCode][ruleCategoryCode][ruleItemType] ) ) { > >- if ( $.inArray( ['restrictedtype', 'accountsent', 'reservecharge'], rule_name ) ) continue; >+ if ( rule_name == "restrictedtype" // obsolete rules >+ || rule_name == "accountsent" >+ || rule_name == "reservecharge") >+ continue; >+ > if (!(rule_name in RULE_KINDS)){ > console.log("A new rule " + rule_name + " has been added but not defined"); > } >-- >2.17.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15522
:
68231
|
68232
|
68233
|
68234
|
68235
|
71048
|
71049
|
71050
|
71051
|
71052
|
72239
|
72242
|
91977
|
91978
|
91979
|
91980
|
91981
|
91982
|
91983
|
91984
|
94201
|
94202
|
94203
|
94204
|
94205
|
94206
|
94207
|
94208
|
99148
|
99149
|
99150
|
99151
|
99152
|
99153
|
99154
|
99155
|
99156
|
99157
|
99199
|
99200
|
99201
|
99202
|
99203
|
99204
|
99205
|
99206
|
99207
|
99208
|
99209
|
99210
|
99211
|
99213
|
99214
|
99215
|
101918
|
101919
|
101920
|
101921
|
101922
|
101923
|
101924
|
101925
|
101926
|
101927
|
101934
|
101935
|
101936
|
101937
|
101938
|
101939
|
101940
|
101941
|
101942
|
101943
|
101944
|
101945
|
101946
|
101947
|
106913
|
106914
|
106915
|
106916
|
106917
|
106918
|
106919
|
106920
|
106921
|
106922
|
106923
|
106924
|
106925
|
106926
|
112056
|
112057
|
112058
|
112059
|
112060
|
112061