Attachment 101929 Details for Bug 24764 – Bug 24764: TinyMCE shouldnt do automatic code cleanup when editing HTML in News Feature

[patch] Bug 24764: TinyMCE shouldnt do automatic code cleanup when editing HTML in News Feature

Bug-24764-TinyMCE-shouldnt-do-automatic-code-clean.patch (text/plain), 1.73 KB, created by David Cook on 2020-03-27 00:19:48 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Cook

Created: 2020-03-27 00:19:48 UTC

Size: 1.73 KB

patch

obsolete

>From aaeee5bf3dd61eaab65955c9925ed8a1d8b5bc2e Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Thu, 26 Mar 2020 22:46:26 +0000
>Subject: [PATCH] Bug 24764: TinyMCE shouldnt do automatic code cleanup when
> editing HTML in News Feature
>
>TEST PLAN:
>1. Make a new news item and use the TinyMCE editor, click on the <> icon to go to the Source code editor
>2. Add some HTML like <i class="fa fa-facebook-official" aria-hidden="true">TEST</i> and save it.
>3. Go back in and notice that TinyMCE has changed it to: <p><em class="fa fa-facebook-official">TEST</em></p>
>4. It should not auto clean up and also it should not autowrap with <p> tag.
>5. Apply patch patch, and repeat step 2. Save again.
>6. It should not have automatiicly changed any HTML or added any <p> wrapper.
>
>Signed-off-by: David Cook <dcook@prosentient.com.au>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/tools/koha-news.tt | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/koha-news.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/koha-news.tt
>index e73e613194..a3ff180cd4 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/koha-news.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/koha-news.tt
>@@ -296,6 +296,10 @@ Edit news item[% ELSE %]Add news item[% END %][% ELSE %]News[% END %]</div>
>     [% INCLUDE 'str/tinymce_i18n.inc' %]
>     <script>
>         tinyMCE.init({
>+            verify_html: false,
>+            force_br_newlines : false,
>+            force_p_newlines : false,
>+            forced_root_block : '',
>             branding : false,
>             content_css : "[% interface | html %]/[% theme | html %]/css/tinymce.css",
>             menubar : "file edit view insert format tools table",
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 24764: 101917 | 101929 | 102778