Bugzilla – Attachment 101954 Details for
Bug 24883
Add `misc/load_yaml.pl` utility script to allow manual loading of yaml data files
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24883: Add POD entry and remove unused variable
Bug-24883-Add-POD-entry-and-remove-unused-variable.patch (text/plain), 1.97 KB, created by
Marcel de Rooy
on 2020-03-27 08:06:42 UTC
(
hide
)
Description:
Bug 24883: Add POD entry and remove unused variable
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2020-03-27 08:06:42 UTC
Size:
1.97 KB
patch
obsolete
>From b519d4de74633e4d9425070313a734909b0b60d8 Mon Sep 17 00:00:00 2001 >From: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> >Date: Fri, 20 Mar 2020 19:35:29 -0300 >Subject: [PATCH] Bug 24883: Add POD entry and remove unused variable >Content-Type: text/plain; charset=utf-8 > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > C4/Installer.pm | 23 ++++++++++++++++------- > misc/load_yaml.pl | 2 +- > 2 files changed, 17 insertions(+), 8 deletions(-) > >diff --git a/C4/Installer.pm b/C4/Installer.pm >index ec56c0e2d0..db247e5243 100644 >--- a/C4/Installer.pm >+++ b/C4/Installer.pm >@@ -473,15 +473,12 @@ sub set_languages_syspref { > C4::Context->clear_syspref_cache(); > } > >-=head2 load_sql >- >- my $error = $installer->load_sql($filename); >+=head2 process_yml_table > >-Runs the specified input file using a sql loader DBIx::RunSQL, or a yaml loader >-Returns any strings sent to STDERR >+ my $query_info = $installer->process_yml_table($table); > >-# FIXME This should be improved: sometimes the caller and load_sql warn the same >-error. >+Analyzes a table loaded in YAML format. >+Returns the values required to build an insert statement. > > =cut > >@@ -506,6 +503,18 @@ sub process_yml_table { > return { query => $query, placeholders => $placeholders, values => \@values }; > } > >+=head2 load_sql >+ >+ my $error = $installer->load_sql($filename); >+ >+Runs the specified input file using a sql loader DBIx::RunSQL, or a yaml loader >+Returns any strings sent to STDERR >+ >+# FIXME This should be improved: sometimes the caller and load_sql warn the same >+error. >+ >+=cut >+ > sub load_sql { > my $self = shift; > my $filename = shift; >diff --git a/misc/load_yaml.pl b/misc/load_yaml.pl >index b12d88d886..118c394e13 100755 >--- a/misc/load_yaml.pl >+++ b/misc/load_yaml.pl >@@ -41,7 +41,7 @@ USAGE > } > > # Getting parameters >-my ( @files, $dump, $load, $help ); >+my ( @files, $load, $help ); > > GetOptions( > 'help|h' => \$help, >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24883
:
100831
|
101009
|
101010
|
101011
|
101012
|
101013
|
101292
|
101293
|
101294
|
101332
|
101333
|
101901
|
101902
|
101903
|
101904
|
101905
|
101950
|
101951
|
101952
|
101953
| 101954