Bugzilla – Attachment 101987 Details for
Bug 23473
Add option to import/overwrite passwords when using the patron import tool
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23473: (follow-up) Fix QA complaints (tabs, filters, Dumper)
Bug-23473-follow-up-Fix-QA-complaints-tabs-filters.patch (text/plain), 2.05 KB, created by
Marcel de Rooy
on 2020-03-27 10:43:56 UTC
(
hide
)
Description:
Bug 23473: (follow-up) Fix QA complaints (tabs, filters, Dumper)
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2020-03-27 10:43:56 UTC
Size:
2.05 KB
patch
obsolete
>From 879fd74c897d2229575d81354dde43f410458de7 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Tue, 4 Feb 2020 12:14:51 +0000 >Subject: [PATCH] Bug 23473: (follow-up) Fix QA complaints (tabs, filters, > Dumper) >Content-Type: text/plain; charset=utf-8 > >--- > koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt | 2 +- > t/db_dependent/Koha/Patrons/Import.t | 1 - > 2 files changed, 1 insertion(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt >index 915525de75..5ee2fadf72 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt >@@ -117,7 +117,7 @@ > [% END %] > [% IF e.passwd_too_short %] > <li class="line_error"> >- Password is too short for patron with borrowernumber [% e.borrowernumber | html %]. Minimum length is [% e.min_length %], length is [% e.length %] >+ Password is too short for patron with borrowernumber [% e.borrowernumber | html %]. Minimum length is [% e.min_length | html %], length is [% e.length | html %] > </li> > [% END %] > [% IF e.passwd_whitespace %] >diff --git a/t/db_dependent/Koha/Patrons/Import.t b/t/db_dependent/Koha/Patrons/Import.t >index 58be76791d..ba46df2966 100644 >--- a/t/db_dependent/Koha/Patrons/Import.t >+++ b/t/db_dependent/Koha/Patrons/Import.t >@@ -494,7 +494,6 @@ subtest 'test_import_with_password_overwrite' => sub { > $ernest->store; > > $result = $patrons_import->import_patrons($params_4, $defaults); >- warn Data::Dumper::Dumper( $result ); > $ernest = Koha::Patrons->find({ userid => 'ErnestP' }); > is($ernest->surname,'Worrell',"Patron is overwritten, surname changed"); > is($ernest->password,$orig_pass,"Patron is imported, password is not changed for staff"); >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23473
:
92352
|
93073
|
93074
|
93594
|
94822
|
95049
|
95050
|
95051
|
95052
|
96998
|
96999
|
97000
|
97001
|
97002
|
97003
|
98382
|
101981
|
101982
|
101983
|
101984
|
101985
|
101986
| 101987 |
101988