Bugzilla – Attachment 101990 Details for
Bug 22001
Add RaiseError and PrintError flags for all tests
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22001: (RM follow-up) Allow RaiseError tests in Reports/Guided.t
Bug-22001-RM-follow-up-Allow-RaiseError-tests-in-R.patch (text/plain), 3.32 KB, created by
Martin Renvoize (ashimema)
on 2020-03-27 11:32:04 UTC
(
hide
)
Description:
Bug 22001: (RM follow-up) Allow RaiseError tests in Reports/Guided.t
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2020-03-27 11:32:04 UTC
Size:
3.32 KB
patch
obsolete
>From 7e72248edac2541fb0cb6250f1f59b08ce6f6a7d Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Fri, 27 Mar 2020 11:12:41 +0000 >Subject: [PATCH] Bug 22001: (RM follow-up) Allow RaiseError tests in > Reports/Guided.t > >--- > t/db_dependent/Reports/Guided.t | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > >diff --git a/t/db_dependent/Reports/Guided.t b/t/db_dependent/Reports/Guided.t >index f9c2b738f7..c8167488cf 100644 >--- a/t/db_dependent/Reports/Guided.t >+++ b/t/db_dependent/Reports/Guided.t >@@ -253,9 +253,8 @@ subtest 'get_saved_reports' => sub { > ); > > # for next test, we want to let execute_query capture any SQL errors >- $dbh->{RaiseError} = 0; > my $errors; >- warning_like { ($sth, $errors) = execute_query( >+ warning_like {local $dbh->{RaiseError} = 0; ($sth, $errors) = execute_query( > 'SELECT surname FRM borrowers', # error in the query is intentional > 0, 10 ) } > qr/^DBD::mysql::st execute failed: You have an error in your SQL syntax;/, >@@ -264,7 +263,6 @@ subtest 'get_saved_reports' => sub { > defined($errors) && exists($errors->{queryerr}), > 'attempting to run a report with an SQL syntax error returns error message (Bug 12214)' > ); >- $dbh->{RaiseError} = 1; > > is_deeply( get_report_areas(), [ 'CIRC', 'CAT', 'PAT', 'ACQ', 'ACC', 'SER' ], > "get_report_areas returns the correct array of report areas"); >@@ -367,6 +365,7 @@ count(h.reservedate) AS 'holds' > subtest 'Email report test' => sub { > > plan tests => 12; >+ my $dbh = C4::Context->dbh; > > my $id1 = $builder->build({ source => 'Borrower',value => { surname => 'mailer', email => 'a@b.com', emailpro => 'b@c.com' } })->{ borrowernumber }; > my $id2 = $builder->build({ source => 'Borrower',value => { surname => 'nomailer', email => undef, emailpro => 'd@e.com' } })->{ borrowernumber }; >@@ -399,7 +398,8 @@ subtest 'Email report test' => sub { > ($emails, $errors ) = C4::Reports::Guided::EmailReport({report_id => $report1, module => $letter1->{module}, code => $letter2->{code}}); > is( $errors->[0]{FATAL}, 'NO_LETTER', "Must have a letter that exists"); > >- warning_like { ($emails, $errors ) = C4::Reports::Guided::EmailReport({report_id => $report2, module => $letter1->{module} , code => $letter1->{code} }) } >+ # for next test, we want to let execute_query capture any SQL errors >+ warning_like { local $dbh->{RaiseError} = 0; ($emails, $errors ) = C4::Reports::Guided::EmailReport({report_id => $report2, module => $letter1->{module} , code => $letter1->{code} }) } > qr/^DBD::mysql::st execute failed/, > 'Error from bad report'; > is( $errors->[0]{FATAL}, 'REPORT_FAIL', "Bad report returns failure"); >@@ -429,6 +429,7 @@ subtest 'nb_rows() tests' => sub { > > plan tests => 3; > >+ my $dbh = C4::Context->dbh; > $schema->storage->txn_begin; > > my $items_count = Koha::Items->search->count; >@@ -448,8 +449,10 @@ subtest 'nb_rows() tests' => sub { > SELECT * items xxx > }; > >+ # for next test, we want to let execute_query capture any SQL errors >+ > warning_like >- { $nb_rows = nb_rows( $bad_query ) } >+ { local $dbh->{RaiseError} = 0; $nb_rows = nb_rows( $bad_query ) } > qr/^DBD::mysql::st execute failed:/, > 'Bad queries raise a warning'; > >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22001
:
83230
|
83231
|
83232
|
98910
|
98911
|
98912
|
99589
|
99590
|
99591
|
101989
| 101990 |
101991
|
102070
|
102140
|
102147
|
102149
|
102150
|
102151
|
102152