Attachment 102059 Details for Bug 25011 – Bug 25011: Improve display of MARC21 508 - Production credits in staff and OPAC

[patch] Bug 25011: Improve display of MARC21 508 - Production credits in staff and OPAC

Bug-25011-Improve-display-of-MARC21-508---Producti.patch (text/plain), 4.62 KB, created by David Nind on 2020-03-29 18:56:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2020-03-29 18:56:36 UTC

Size: 4.62 KB

patch

obsolete

>From 9842d8aef17818586f7b0729d44de9e74c1ca249 Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <katrin.fischer.83@web.de>
>Date: Fri, 27 Mar 2020 23:48:56 +0100
>Subject: [PATCH] Bug 25011: Improve display of MARC21 508 - Production credits
> in staff and OPAC
>
>Makes some tiny changes to improve display and consistency between
>OPAC and staff:
>- Capitalization fix: Production Credits - Production credits
>- Changes div to span avoiding display issues
>- Make sequence of fields in display match (505, 508, 586)
>
>To test:
>- Catalog one or more records with none, one and multiple 508 $a
>- Check and compare the staff and OPAC detail pages, both
> should display the production credits information correctly
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> .../prog/en/xslt/MARC21slim2intranetDetail.xsl | 26 +++++++++++-----------
> .../bootstrap/en/xslt/MARC21slim2OPACDetail.xsl | 22 +++++++++---------
> 2 files changed, 24 insertions(+), 24 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl
>index d44322d6ff..e00cbb99d9 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl
>+++ b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl
>@@ -1009,6 +1009,19 @@
> 
> </xsl:if>
> 
>+ 
>+ <xsl:if test="marc:datafield[@tag=508]">
>+ 
>+ Production credits: 
>+ <xsl:for-each select="marc:datafield[@tag=508]">
>+ <xsl:call-template name="subfieldSelectSpan">
>+ <xsl:with-param name="codes">a</xsl:with-param>
>+ </xsl:call-template>
>+ <xsl:if test="position()!=last()"><xsl:text> | </xsl:text></xsl:if>
>+ </xsl:for-each>
>+ 
>+ </xsl:if>
>+
> 
> <xsl:if test="marc:datafield[@tag=583]">
> <xsl:for-each select="marc:datafield[@tag=583]">
>@@ -1030,19 +1043,6 @@
> </xsl:for-each>
> </xsl:if>
> 
>- 
>- <xsl:if test="marc:datafield[@tag=508]">
>- <div class="results_summary prod_credits">
>- Production credits: 
>- <xsl:for-each select="marc:datafield[@tag=508]">
>- <xsl:call-template name="subfieldSelectSpan">
>- <xsl:with-param name="codes">a</xsl:with-param>
>- </xsl:call-template>
>- <xsl:if test="position()!=last()"><xsl:text> | </xsl:text></xsl:if>
>- </xsl:for-each>
>- </div>
>- </xsl:if>
>-
> 
> <xsl:if test="marc:datafield[@tag=773]">
> <xsl:for-each select="marc:datafield[@tag=773]">
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl
>index 0ade99700c..cd0bf1c109 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl
>@@ -1103,17 +1103,17 @@
> </xsl:if>
> 
> 
>- <xsl:if test="marc:datafield[@tag=508]">
>- <div class="results_summary prod_credits">
>- Production Credits: 
>- <xsl:for-each select="marc:datafield[@tag=508]">
>- <xsl:call-template name="subfieldSelectSpan">
>- <xsl:with-param name="codes">a</xsl:with-param>
>- </xsl:call-template>
>- <xsl:if test="position()!=last()"><xsl:text> | </xsl:text></xsl:if>
>- </xsl:for-each>
>- </div>
>- </xsl:if>
>+ <xsl:if test="marc:datafield[@tag=508]">
>+ 
>+ Production credits: 
>+ <xsl:for-each select="marc:datafield[@tag=508]">
>+ <xsl:call-template name="subfieldSelectSpan">
>+ <xsl:with-param name="codes">a</xsl:with-param>
>+ </xsl:call-template>
>+ <xsl:if test="position()!=last()"><xsl:text> | </xsl:text></xsl:if>
>+ </xsl:for-each>
>+ 
>+ </xsl:if>
> 
> 
> <xsl:if test="marc:datafield[@tag=586]">
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 25011: 102022 | 102024 | 102059 | 103119