Bugzilla – Attachment 102060 Details for
Bug 25007
AmazonCoverImages doesnt check for ISBN in details.tt
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25007: Check for normaalized ISBN when building Amazon link
Bug-25007-Check-for-normaalized-ISBN-when-building.patch (text/plain), 1.90 KB, created by
David Nind
on 2020-03-29 19:22:31 UTC
(
hide
)
Description:
Bug 25007: Check for normaalized ISBN when building Amazon link
Filename:
MIME Type:
Creator:
David Nind
Created:
2020-03-29 19:22:31 UTC
Size:
1.90 KB
patch
obsolete
>From c6174e440a29bac41a7cf89bfa5a22725f5caea2 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Fri, 27 Mar 2020 20:40:30 +0000 >Subject: [PATCH] Bug 25007: Check for normaalized ISBN when building Amazon > link > >TO RECREATE: >-Have Amazon images turned on and local images too. >-Have a record with a local cover image >-Make sure the record has no ISBN in 020 field. >-Load detail page of that record and see that the local cover images is > not on the right hand side like it should be but forced underneath > 'catalogue_detail_biblio' in an odd spot. >-Apply patch and reload page >-The image should be back in its normal spot > >Signed-off-by: David Nind <david@davidnind.com> >Signed-off-by: Owen Leonard <oleonard@myacpl.org> > >Signed-off-by: David Nind <david@davidnind.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >index 6ef518489b..8b4be7c6e3 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >@@ -143,7 +143,7 @@ > [% IF ( AdlibrisEnabled && normalized_isbn ) %] > <a href="[% AdlibrisURL | url %]?isbn=[% normalized_isbn | uri %]"><img src="[% AdlibrisURL | url %]?isbn=[% normalized_isbn | uri %]" class="adlibris-cover-big" alt="Adlibris cover image" /></a> > [% END %] >- [% IF ( AmazonCoverImages ) %] >+ [% IF ( AmazonCoverImages && normalized_isbn) %] > <div id="amazon-bookcoverimg"> > <a href="http://www.amazon[% AmazonTld | uri %]/gp/reader/[% normalized_isbn | uri %][% AmazonAssocTag | uri %]#reader-link"> > <img src="https://images-na.ssl-images-amazon.com/images/P/[% normalized_isbn | html %].01.MZZZZZZZ.jpg" alt="" /> >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25007
:
102018
|
102054
|
102056
|
102057
|
102060
|
102061
|
102062
|
102063
|
103034
|
103035
|
103036
|
103064
|
103065