Attachment 102104 Details for Bug 24474 – Bug 24474: (QA follow-up) Fix failing test

[patch] Bug 24474: (QA follow-up) Fix failing test

Bug-24474-QA-follow-up-Fix-failing-test.patch (text/plain), 1.14 KB, created by Martin Renvoize (ashimema) on 2020-03-31 08:45:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2020-03-31 08:45:43 UTC

Size: 1.14 KB

patch

obsolete

>From 905643c771cb3590fdbd621538abe2eef86ed8ae Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Tue, 31 Mar 2020 09:43:34 +0100
>Subject: [PATCH] Bug 24474: (QA follow-up) Fix failing test
>
>The test was assuming default data and would fail if you ran through the
>test plan (and disabled all but `onpayment` for the
>'MarkLostItemsAsReturned' preference) on the data before running the
>included unit tests.
>---
> t/db_dependent/Circulation.t | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t
>index f4a6c37092..d0c97ec0b0 100755
>--- a/t/db_dependent/Circulation.t
>+++ b/t/db_dependent/Circulation.t
>@@ -2337,6 +2337,7 @@ subtest 'CanBookBeIssued + AutoReturnCheckedOutItems' => sub {
> subtest 'AddReturn | is_overdue' => sub {
>     plan tests => 5;
> 
>+    t::lib::Mocks::mock_preference('MarkLostItemsAsReturned', 'batchmod|moredetail|cronjob|additem|pendingreserves|onpayment');
>     t::lib::Mocks::mock_preference('CalculateFinesOnReturn', 1);
>     t::lib::Mocks::mock_preference('finesMode', 'production');
>     t::lib::Mocks::mock_preference('MaxFine', '100');
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 24474: 98392 | 98393 | 98436 | 98437 | 98438 | 98439 | 98460 | 98485 | 98486 | 98487 | 98645 | 98646 | 98647 | 98648 | 98673 | 98674 | 98675 | 98676 | 98923 | 100229 | 100230 | 100231 | 100232 | 100233 | 102104 | 102105 | 102106 | 102107 | 102108 | 102109 | 102110 | 102132 | 102133 | 102134 | 102135 | 102136 | 102137 | 102138