Attachment 102135 Details for Bug 24474 – Bug 24474: Filter out LOST_FOUND

[patch] Bug 24474: Filter out LOST_FOUND

Bug-24474-Filter-out-LOSTFOUND.patch (text/plain), 1.61 KB, created by Kyle M Hall (khall) on 2020-03-31 13:56:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2020-03-31 13:56:59 UTC

Size: 1.61 KB

patch

obsolete

>From 3d7b953ceae5e35aa5c37196deb7a30f9ddac398 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Wed, 5 Feb 2020 13:10:49 +0000
>Subject: [PATCH] Bug 24474: Filter out LOST_FOUND
>
>Signed-off-by: David Nind <david@davidnind.com>
>
>Signed-off-by: David Nind <david@davidnind.com>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> Koha/Account/Line.pm | 18 +++++++++++++-----
> 1 file changed, 13 insertions(+), 5 deletions(-)
>
>diff --git a/Koha/Account/Line.pm b/Koha/Account/Line.pm
>index 8f10ac3ace..155ae4e29b 100644
>--- a/Koha/Account/Line.pm
>+++ b/Koha/Account/Line.pm
>@@ -492,14 +492,22 @@ sub apply {
>             }
> 
>             # Same logic exists in Koha::Account::pay
>-            if (   $debit->amountoutstanding == 0
>-                && $debit->itemnumber
>+            if (
>+                C4::Context->preference('MarkLostItemsAsReturned') =~
>+                m|onpayment|
>                 && $debit->debit_type_code
>-                && $debit->debit_type_code eq 'LOST' )
>+                && $debit->debit_type_code eq 'LOST'
>+                && $debit->amountoutstanding == 0
>+                && $debit->itemnumber
>+                && !(
>+                       $self->credit_type_code eq 'LOST_FOUND'
>+                    && $self->itemnumber == $debit->itemnumber
>+                )
>+              )
>             {
>-                C4::Circulation::ReturnLostItem( $self->borrowernumber, $debit->itemnumber );
>+                C4::Circulation::ReturnLostItem( $self->borrowernumber,
>+                    $debit->itemnumber );
>             }
>-
>         }
>     });
> 
>-- 
>2.24.1 (Apple Git-126)

Actions: View | Diff | Splinter Review

Attachments on bug 24474: 98392 | 98393 | 98436 | 98437 | 98438 | 98439 | 98460 | 98485 | 98486 | 98487 | 98645 | 98646 | 98647 | 98648 | 98673 | 98674 | 98675 | 98676 | 98923 | 100229 | 100230 | 100231 | 100232 | 100233 | 102104 | 102105 | 102106 | 102107 | 102108 | 102109 | 102110 | 102132 | 102133 | 102134 | 102135 | 102136 | 102137 | 102138