Bugzilla – Attachment 102215 Details for
Bug 25022
Display problem in authority editor with repeatable field
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25022: Display problem in authority editor with repeatable field
Bug-25022-Display-problem-in-authority-editor-with.patch (text/plain), 2.40 KB, created by
Marcel de Rooy
on 2020-04-01 12:13:24 UTC
(
hide
)
Description:
Bug 25022: Display problem in authority editor with repeatable field
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2020-04-01 12:13:24 UTC
Size:
2.40 KB
patch
obsolete
>From f88afbcd16ecf0ac7a2982000c807a6092b130c1 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 31 Mar 2020 14:20:23 +0000 >Subject: [PATCH] Bug 25022: Display problem in authority editor with > repeatable field >Content-Type: text/plain; charset=utf-8 > >This patch corrects an error in the structure of the authority editor >template so that repeating subfields do not generate invalid markup. The >correction was found by comparing with addbiblio.tt. > >If you are viewing the diff, please note that some minor whitespace >changes have been made. > >To reproduce, clone and and populate any repeatable subfield, save, and >open the authority for editing again. The clones subfield will be >formatting incorrectly, showing bullet points on each line. > >To test, apply the patch and reload the authority editor showing the >record with the cloned subfield. It should display correctly. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > .../prog/en/modules/authorities/authorities.tt | 25 ++++++++++------------ > 1 file changed, 11 insertions(+), 14 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt >index 55ddb49f4c..76c1df8ceb 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt >@@ -406,20 +406,17 @@ function confirmnotdup(redirect){ > </a> > [% END %] > </span> >- >- </li> >- <!-- End of the line --> >- [% END %] >- >- </ul> <!-- /.sortable_subfield --> >- </li> >- [% END %]<!-- if innerloo.tag --> >- </ul> <!-- /.sortable_field --> >- [% END %]<!-- BIG_LOO.innerloop --> >- </div> >-[% END %]<!-- BIG_LOOP --> >- >-</div><!-- tabs --> >+ </li> >+ <!-- End of the line --> >+ [% END %] >+ </ul> <!-- /.sortable_subfield --> >+ </li> >+ [% END %]<!-- if innerloo.tag --> >+ [% END %]<!-- BIG_LOO.innerloop --> >+ </ul> <!-- /.sortable_field --> >+ </div> >+ [% END %]<!-- BIG_LOOP --> >+ </div><!-- tabs --> > > <div name="hidden" id="hidden" class="tab"> > [% FOREACH hidden_loo IN hidden_loop %] >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25022
:
102125
|
102143
| 102215