Attachment 102289 Details for Bug 23173 – Bug 23173: (follow-up) Allow for wide characters

[patch] Bug 23173: (follow-up) Allow for wide characters

Bug-23173-follow-up-Allow-for-wide-characters.patch (text/plain), 1.37 KB, created by Kyle M Hall (khall) on 2020-04-02 11:59:07 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2020-04-02 11:59:07 UTC

Size: 1.37 KB

patch

obsolete

>From 5912d6037a9e4cb88337559d9b4d8e8c594399be Mon Sep 17 00:00:00 2001
>From: Andrew Isherwood <andrew.isherwood@ptfs-europe.com>
>Date: Thu, 6 Feb 2020 11:08:41 +0000
>Subject: [PATCH] Bug 23173: (follow-up) Allow for wide characters
>
>The conversion of the metadata into Base64 for passing in the API call
>to the plugin API routes was failing if the metadata contained a wide
>character, so we now encode it into UTF-8 first
>
>Signed-off-by: Niamh Walker-Headon <Niamh.Walker-Headon@tudublin.ie>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> Koha/Illrequest/Availability.pm | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/Koha/Illrequest/Availability.pm b/Koha/Illrequest/Availability.pm
>index 099f88596e..a9ca6efd4d 100644
>--- a/Koha/Illrequest/Availability.pm
>+++ b/Koha/Illrequest/Availability.pm
>@@ -21,7 +21,8 @@ use Modern::Perl;
> 
> use JSON;
> use MIME::Base64 qw( encode_base64 );
>-use URI::Escape qw ( uri_escape );
>+use URI::Escape qw( uri_escape );
>+use Encode qw( encode );
> 
> use Koha::Plugins;
> 
>@@ -114,7 +115,7 @@ sub prep_metadata {
>     # so this function returns something predictable that we can test!
>     my $json = JSON->new;
>     $json->canonical([1]);
>-    return uri_escape(encode_base64($json->encode($metadata)));
>+    return uri_escape(encode_base64(encode('utf-8',$json->encode($metadata))));
> }
> 
> =head1 AUTHOR
>-- 
>2.24.1 (Apple Git-126)

Actions: View | Diff | Splinter Review

Attachments on bug 23173: 91464 | 91465 | 92107 | 92108 | 92539 | 92540 | 92550 | 92551 | 92640 | 92641 | 92693 | 92694 | 92695 | 92715 | 92716 | 92717 | 93146 | 93147 | 93148 | 93909 | 93910 | 93911 | 95268 | 95269 | 95270 | 98521 | 99083 | 100724 | 100725 | 100740 | 102179 | 102180 | 102181 | 102182 | 102183 | 102184 | 102286 | 102287 | 102288 | 102289 | 102290 | 102291 | 102292 | 102293 | 102294