Attachment 102337 Details for Bug 25041 – Bug 25041: Restore #ASKED anchor in suggestions table

[patch] Bug 25041: Restore #ASKED anchor in suggestions table

Bug-25041-Restore-ASKED-anchor-in-suggestions-tabl.patch (text/plain), 2.26 KB, created by Jonathan Druart on 2020-04-03 09:46:00 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2020-04-03 09:46:00 UTC

Size: 2.26 KB

patch

obsolete

>From 45f1552cd6e62c5c281f48f06c9a223c786ad74e Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Fri, 3 Apr 2020 11:42:59 +0200
>Subject: [PATCH] Bug 25041: Restore #ASKED anchor in suggestions table
>
>On commit 4494e8ba6ca7d28972fcc1161c680ecf0b091f62
>   Bug 23594: Batch modification for itemtypes on suggestions page
>The anchors of the tabs on suggestion.pl has been replaced with
>tab_$count instead of the status code.
>There was a need at the time, but I cannot remember it.
>I restored the previous behavior, and did not find any regressions.
>
>Test plan:
>1 - Add several suggestions to Koha
>2 - Set them in different status, leaving at least one pending
>3 - Go to home page, note it shows count of pending
>4 - Click the link on home page
>5 - It takes you to correct tab
>---
> .../intranet-tmpl/prog/en/modules/suggestion/suggestion.tt  | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
>index a430fd5d04..af3659c5ca 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
>@@ -514,7 +514,7 @@
>     <ul class="ui-tabs-nav">
>         [% FOREACH suggestion IN suggestions %]
>                 <li>
>-            <a href="#tab_[% loop.count | uri %]">
>+            <a href="#[% suggestion.suggestiontype | uri %]">
>             [% IF ( suggestion.suggestiontypelabel ) %]
>                 [% IF (suggestion.suggestiontypelabel == "Pending") %]Pending
>                 [% ELSIF (suggestion.suggestiontypelabel == "Accepted") %]Accepted
>@@ -538,8 +538,8 @@
> [% END %]
> 
> [% FOREACH suggestion IN suggestions %]
>-<div id="tab_[% loop.count | html %]">
>-<form class="update_suggestions" name="f" method="post" action="/cgi-bin/koha/suggestion/suggestion.pl#tab_[% loop.count | html %]">
>+<div id="[% suggestion.suggestiontype | html %]">
>+<form class="update_suggestions" name="f" method="post" action="/cgi-bin/koha/suggestion/suggestion.pl#[% suggestion.suggestiontype| uri %]">
> 
> [% IF ( suggestion.suggestions_loop ) %]
> <p><a class="checkall" href="#">Check all</a> | <a class="uncheckall" href="#">Uncheck all</a></p>
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 25041: 102337 | 102402 | 102462